661014 - [fennec][japanese]Password Manager notification gets truncated when viewing in portrait mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

Mozilla/5.0 (Android; Linux armv71; rv5.0) Gecko/20110527 Firefox/5.0 Fennec/5.0
Device: Thunderbolt
OS: Android 2.2

1. set device in portrait mode
2. go to www.google.com
3. select classic/PC on website
4. login

Expected: the notification fits on screen
Actual: the notification gets truncated

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

probably a dup of bug 661889, now that notification buttons have changed.  need to recheck each language.

Comment 2

[Axel Hecht [:Pike]]

(In reply to comment #1)
> probably a dup of bug 661889, now that notification buttons have changed. 
> need to recheck each language.

Mark, can you help me out with context here?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> (In reply to comment #1)
> > probably a dup of bug 661889, now that notification buttons have changed. 
> > need to recheck each language.
> 
> Mark, can you help me out with context here?

Axel, bug 661889 has a patch on it to allow the notification box buttons to wrap to a second line if the buttons want to overflow off the screen. Many of the locales (and even en-US in a desktop case) are hitting this problem. I made a patch to let the buttons wrap, which would mean many of these problems would go away.

I should have filed a new bug and put the patch there, instead of on a locale bug.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

To note, the fix for bug 661889 is in aurora but not in beta.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

If bug 661889 fixes this bug, mark this bug fixed too.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Fixed in Aurora/Nightly, not in Beta.

Comment 7

[Aaron Train [:aaronmt]]

Veri fixed via bug 661889