Closed Bug 661889 Opened 9 years ago Closed 9 years ago

Wrap notification buttons onto a second row instead of cropping the overflow

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 7

People

(Reporter: nhirata, Assigned: mfinkle)

References

Details

Attachments

(4 files)

Mozilla/5.0 (Android; Linux armv71; rv5.0) Gecko/20110527 Firefox/5.0 Fennec/5.0
Device: Thunderbolt
OS: Android 2.2

1. set browser to italian
2. set browser to portrait mode
3. go to http://popuptest.com/popuptest1.html or http://vingtetun.org/todo/

Expected: the notification fits to page
Actual: the notification gets truncated
Can those buttons be displayed on two rows instead of one? Honestly I can't see any way to translate those labels in order to fit that tiny space.
Assignee: l10n-it → francesco.lodolo
OK, we can get the buttons to wrap. CC'ing Madhava so he is aware.
Attached patch patchSplinter Review
This patch allows the buttons to wrap for all notifications. We use the button bottom margin to create inter-button spacing and a bottom margin for the notification box itself.

The button CSS can't be in notification.css, since that CSS is not applied to non-XBL elements - like the buttons.
Assignee: francesco.lodolo → mark.finkle
Attachment #537201 - Flags: review?(21)
This change may affect other languages such as portugese, etc. etc.  Need to retest on a patch build.
longest button is probably finnish; see screenshot of login at google.
Wouldn't be better to update summary and component of this bug?
Summary: [fennec][italian]popup notification and offline notification will truncate in portrait mode → Wrap notification buttons onto a second row instead of cropping the overflow
Component: it / Italian → General
Product: Mozilla Localizations → Fennec
QA Contact: prometeo.bugs → general
Version: unspecified → Trunk
http://hg.mozilla.org/mozilla-central/rev/830f03c194a9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
So, should we fix bug 661879 then? Is this going to be backported to aurora and beta?
Verified fixed

Build Identifier: Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110608 Firefox/7.0a1 Fennec/7.0a1
Status: RESOLVED → VERIFIED
Depends on: 662781
(In reply to comment #9)
> So, should we fix bug 661879 then? Is this going to be backported to aurora
> and beta?

It will fix bug 661879. We won't port to beta but we could port to aurora.
You need to log in before you can comment on or make changes to this bug.