661889 - Wrap notification buttons onto a second row instead of cropping the overflow

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: offline storage screenshot

Mozilla/5.0 (Android; Linux armv71; rv5.0) Gecko/20110527 Firefox/5.0 Fennec/5.0
Device: Thunderbolt
OS: Android 2.2

1. set browser to italian
2. set browser to portrait mode
3. go to http://popuptest.com/popuptest1.html or http://vingtetun.org/todo/

Expected: the notification fits to page
Actual: the notification gets truncated

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: popup screenshot

Comment 2

[Francesco Lodolo [:flod]]

Can those buttons be displayed on two rows instead of one? Honestly I can't see any way to translate those labels in order to fit that tiny space.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

OK, we can get the buttons to wrap. CC'ing Madhava so he is aware.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch allows the buttons to wrap for all notifications. We use the button bottom margin to create inter-button spacing and a bottom margin for the notification box itself.

The button CSS can't be in notification.css, since that CSS is not applied to non-XBL elements - like the buttons.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This change may affect other languages such as portugese, etc. etc.  Need to retest on a patch build.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: login screenshot (finnish)

longest button is probably finnish; see screenshot of login at google.

Comment 7

[Francesco Lodolo [:flod]]

Wouldn't be better to update summary and component of this bug?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mozilla-central/rev/830f03c194a9

Comment 9

[Guillermo López :willyaranda (probably SLOW response)]

So, should we fix bug 661879 then? Is this going to be backported to aurora and beta?

Comment 10

[Aaron Train [:aaronmt]]

Verified fixed

Build Identifier: Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110608 Firefox/7.0a1 Fennec/7.0a1

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #9)
> So, should we fix bug 661879 then? Is this going to be backported to aurora
> and beta?

It will fix bug 661879. We won't port to beta but we could port to aurora.