661132 - Fix test for bug 642338 so it doesn't rely on firefox.js prefs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Justin Lebar (not reading bugmail)]

The test I added in bug 642338 relies on a Firefox-specific pref, that you can't hide the location bar.  Since this is a core test, it shouldn't rely on this pref being set.

Comment 1

[Frédéric Buclin]

Wrong bug ID.

Comment 2

[Justin Lebar (not reading bugmail)]

Thanks.

Comment 3

[Serge Gautherie (:sgautherie)]

Bug 642338 comment 37:
{
Serge Gautherie (:sgautherie)      2011-05-31 17:07:04 PDT

> If not, I'll review a patch to modify the test so it checks the pref before
> the is() call.

To be explicit, is() check is fine in both cases, but its expected value should simply depend on "dom.disable_window_open_feature.location"(!?) preference value.
}

More details are in bug 653996.

Comment 4

[Justin Lebar (not reading bugmail)]

So just to be clear, I *can* rely on a pref in all.js?

> pref("dom.disable_window_open_feature.status",      true);

Comment 5

[Justin Lebar (not reading bugmail)]

Attachment: Patch v1

Comment 6

[Justin Lebar (not reading bugmail)]

> So just to be clear, I *can* rely on a pref in all.js?

Actually, nevermind.  That's not necessary.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 537580 [details] [diff] [review]
Patch v1

[Mozilla/5.0 (Windows NT 5.0; rv:7.0a1) Gecko/20110605 Firefox/7.0a1 SeaMonkey/2.2a1pre] (nightly, SM 2.4a1pre !)

I like this code. And it fixes bug 653996 :-)

From my bug 653996 comment 3:
{
Nit: you might want to add "from HTML" (or "content" or whatever applies) to the comment, "ftr".
}

Comment 8

[Justin Lebar (not reading bugmail)]

Attachment: Patch v2

Comment 9

[Justin Lebar (not reading bugmail)]

Comment on attachment 537657 [details] [diff] [review]
Patch v2

I meant to ask for Smaug's review on this patch, but I apparently missed that.

Comment 10

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mozilla-central/rev/1b46a093e413