Fix test for bug 642338 so it doesn't rely on firefox.js prefs

RESOLVED FIXED in mozilla7

Status

()

Core
DOM
--
major
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

(Blocks: 1 bug)

Trunk
mozilla7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(status2.0 unaffected)

Details

(Whiteboard: [Blocks (SM) bug 653996] [good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
The test I added in bug 642338 relies on a Firefox-specific pref, that you can't hide the location bar.  Since this is a core test, it shouldn't rely on this pref being set.
(Assignee)

Updated

6 years ago
Depends on: 652338

Comment 1

6 years ago
Wrong bug ID.
No longer depends on: 652338
(Assignee)

Updated

6 years ago
Blocks: 642338
(Assignee)

Comment 2

6 years ago
Thanks.
Bug 642338 comment 37:
{
Serge Gautherie (:sgautherie)      2011-05-31 17:07:04 PDT

> If not, I'll review a patch to modify the test so it checks the pref before
> the is() call.

To be explicit, is() check is fine in both cases, but its expected value should simply depend on "dom.disable_window_open_feature.location"(!?) preference value.
}

More details are in bug 653996.
Blocks: 653996
Severity: normal → major
Whiteboard: [Blocks (SM) bug 653996] [good first bug]
Version: unspecified → Trunk
(Assignee)

Comment 4

6 years ago
So just to be clear, I *can* rely on a pref in all.js?

> pref("dom.disable_window_open_feature.status",      true);
(Assignee)

Comment 5

6 years ago
Created attachment 537580 [details] [diff] [review]
Patch v1
(Assignee)

Comment 6

6 years ago
> So just to be clear, I *can* rely on a pref in all.js?

Actually, nevermind.  That's not necessary.
(Assignee)

Updated

6 years ago
Assignee: nobody → justin.lebar+bug
(Assignee)

Updated

6 years ago
Attachment #537580 - Flags: feedback?(sgautherie.bz)
Comment on attachment 537580 [details] [diff] [review]
Patch v1

[Mozilla/5.0 (Windows NT 5.0; rv:7.0a1) Gecko/20110605 Firefox/7.0a1 SeaMonkey/2.2a1pre] (nightly, SM 2.4a1pre !)

I like this code. And it fixes bug 653996 :-)

From my bug 653996 comment 3:
{
Nit: you might want to add "from HTML" (or "content" or whatever applies) to the comment, "ftr".
}
Attachment #537580 - Flags: feedback?(sgautherie.bz) → feedback+
Status: NEW → ASSIGNED
status2.0: --- → unaffected
(Assignee)

Comment 8

6 years ago
Created attachment 537657 [details] [diff] [review]
Patch v2
(Assignee)

Updated

6 years ago
Attachment #537580 - Attachment is obsolete: true
(Assignee)

Comment 9

6 years ago
Comment on attachment 537657 [details] [diff] [review]
Patch v2

I meant to ask for Smaug's review on this patch, but I apparently missed that.
Attachment #537657 - Flags: review?(Olli.Pettay)

Updated

6 years ago
Attachment #537657 - Flags: review?(Olli.Pettay) → review+
http://hg.mozilla.org/mozilla-central/rev/1b46a093e413
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.