Closed
Bug 661142
Opened 13 years ago
Closed 13 years ago
nsIAbCard.idl needs noscripts stripped so that nsIAbCard can be implemented in JS.
Categories
(Thunderbird :: Address Book, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 7.0
People
(Reporter: mconley, Assigned: mconley)
Details
Attachments
(1 file, 1 obsolete file)
3.88 KB,
patch
|
Bienvenu
:
review+
standard8
:
superreview+
|
Details | Diff | Splinter Review |
nsIAbCard.idl currently has 8 members marked [noscript], which means that nsIAbCard cannot be fully implemented in Javascript. These should be removed.
Assignee | ||
Comment 1•13 years ago
|
||
Since I'm altering an interface (albeit only slightly), should I request super-review?
Comment 2•13 years ago
|
||
Comment on attachment 536602 [details] [diff] [review] Patch v1 - removing noscripts from nsIAbCard.idl I'd extend the comment about js users to include the fact that js does the type conversion automatically.
Attachment #536602 -
Flags: review?(dbienvenu) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Thanks for the review! I've updated the comments so that we mention that type conversion is performed by XPConnect automagically.
Attachment #536602 -
Attachment is obsolete: true
Attachment #536710 -
Flags: review?(dbienvenu)
Updated•13 years ago
|
Attachment #536710 -
Flags: review?(dbienvenu) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 4•13 years ago
|
||
Comment on attachment 536710 [details] [diff] [review] Patch v2 Strictly speaking this should have sr as it is an API change. I'm happy with it though so sr=me. Although I have just noticed that the second part of the change breaks the comments around the grouped function, but I'll fix that on check in.
Attachment #536710 -
Flags: superreview+
Comment 5•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/d871692cdeb9
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
Comment 6•13 years ago
|
||
What happens if some idiot extension author tries to use the previously noscript methods from JS? Do we recover gracefully from this misuse or will bad things happen?
Comment 7•13 years ago
|
||
If they use the appropriate function for the property, then it should still work I believe, though I'm not sure if it would affect perf using the alternate functions.
You need to log in
before you can comment on or make changes to this bug.
Description
•