661145 - always_inline incorrectly set when building with clang

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

AC_TRY_COMPILE expands into main with the user provide code in it. In this case, it looks like

int main(void) {
inline void f(void) __attribute__((always_inline));
}

This fails with

test.cc:2:1: error: inline declaration of 'f' not allowed in block scope
inline void f(void) __attribute__((always_inline));
^~~~~~
1 error generated.

Comment 1

[Benjamin Smedberg]

Comment on attachment 536604 [details] [diff] [review]
patch

Why not just move the declaration into the first block of AC_TRY_COMPILE where it belongs?

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: move declarations out of main

Comment 3

[(no longer active)]

http://hg.mozilla.org/projects/cedar/rev/385822ac7499

Comment 4

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/385822ac7499

Comment 5

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

I visually inspected the code changes. Marking as Verified Fixed as per bug 659997 Comment 7.