Refactor utils.js clipboard flavors

RESOLVED FIXED

Status

Other Applications
DOM Inspector
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: crussell, Assigned: crussell)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

// TODO: Move these (or similar) to jsutil/system/clipboardFlavors.js or
// something as part of bug 328878.

I actually want to do this as a prerequisite to bug 546170.

Two things:
1. Rename CSSDeclaration to CSSProperty.  Style declarations are not properties.  This probably contributed to the confusion in bug 536012 (comment 8).
2. Move it and DOMAttribute to jsutil/system/clipboardFlavors.js
Assignee: nobody → Sevenspade
Status: NEW → ASSIGNED
Created attachment 536912 [details] [diff] [review]
Phase 1: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js [pushed in comment 4]

The license block stuff is based on these two changesets:
http://hg.mozilla.org/dom-inspector/rev/402a613487b6 (i.e., bug 338383)
http://hg.mozilla.org/dom-inspector/rev/0809873fb812 (i.e., bug 341256)

You can see that, besides me, those are the only two to have ever touched the code:
http://hg.mozilla.org/dom-inspector/annotate/7056acde111a/resources/content/utils.js#l178
http://hg.mozilla.org/dom-inspector/annotate/cac8571880ea/resources/content/utils.js#l193
Attachment #536912 - Flags: review?(neil)
Created attachment 536913 [details] [diff] [review]
Phase 2: Rename CSSDeclaration to CSSProperty and make entailing viewer changes [pushed in comment 4]
Attachment #536913 - Flags: review?(neil)
Attachment #536912 - Attachment description: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js → Phase 1: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js
Attachment #536913 - Attachment description: Rename CSSDeclaration to CSSProperty and make entailing viewer changes → Phase 2: Rename CSSDeclaration to CSSProperty and make entailing viewer changes
No longer depends on: 172302

Comment 3

7 years ago
Comment on attachment 536912 [details] [diff] [review]
Phase 1: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js [pushed in comment 4]

Sorry for the delay. I don't have a trunk build that knows how to handle file copies but then I realised that my branch build pulls trunk inspector anyway.
Attachment #536912 - Flags: review?(neil) → review+

Updated

7 years ago
Attachment #536913 - Flags: review?(neil) → review+
Comment on attachment 536912 [details] [diff] [review]
Phase 1: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js [pushed in comment 4]

Pushed:
http://hg.mozilla.org/dom-inspector/rev/38f7c7d8867c
http://hg.mozilla.org/dom-inspector/rev/63179abb9bd5
Attachment #536912 - Attachment description: Phase 1: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js → Phase 1: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js [pushed in comment 4]
Attachment #536913 - Attachment description: Phase 2: Rename CSSDeclaration to CSSProperty and make entailing viewer changes → Phase 2: Rename CSSDeclaration to CSSProperty and make entailing viewer changes [pushed in comment 4]
Blocks: 635356
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
No longer blocks: 635356
You need to log in before you can comment on or make changes to this bug.