661742 - Implement Click-to-web

Status: RESOLVED WONTFIX

(Thunderbird :: Mail Window Front End, defect)

Description

[Jim Porter (:squib)]

In content tabs, there doesn't seem to be a way to navigate back and forward. At minimum, we should add context menu items for them. Hotkeys (alt-left and alt-right) would be nice too. We could also hook up the "back" and "forward" toolbar buttons to navigate the page, but that's probably not necessary in the short term.

Comment 1

[Mark Banner (:standard8)]

Is there a specific use case for this in Thunderbird currently? We originally kept it light weight because the only real uses of content tabs where single/few page versions. Although I guess AMO browsing might now be one case.

At the time we introduced content tabs, we felt that if extensions were providing content tabs which could navigate through sites, as they'd probably also want to think about security UI.

Comment 2

[David Ascher (:davida)]

search results tabs is one use case.

Comment 3

[Jim Porter (:squib)]

Yeah, AMO and the opensearch add-on are the two cases I'm thinking of.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Here's my first run at giving back/forth capabilities to content tabs, as well as giving the user the ability to open links in content tabs, as well as their default browser.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v2

Whoops, forgot to include a new file.

Comment 6

[Jim Porter (:squib)]

Do we actually want to default to opening links in content tabs? That seems wrong.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v3

Some bit-rotting issues got fixed in this patch.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

squib:

Not sure if it's going to be the default yet.  Hopefully, the forthcoming Click-to-web Feature page will tell us more.

-Mike

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: WIP Patch v3

Moved the URIUtils.js file to somewhere that makes more sense.

We now show an in-content dialog to allow the user to opt-in to Click-to-web.  There's some nonsense wording in there right now that I need to fix still.

Comment 10

[Ludovic Hirlimann [:Usul]]

(In reply to Mike Conley (:mconley) from comment #8)
> squib:
> 
> Not sure if it's going to be the default yet.  Hopefully, the forthcoming
> Click-to-web Feature page will tell us more.

Url ?

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Ludo:

I understood that Jb was going to create that feature page - CC'ing him for more information.

-Mike

Comment 12

[Jb Piacentino]

This is on my Todo list. I'll propose a first version ASAP (tonight, maybe).

Comment 13

[Jb Piacentino]

This bug is being revisited as the App Tab feature for gSoC: https://wiki.mozilla.org/Community:SummerOfCode12#Thunderbird, probably as gSoC

Comment 14

[Jim Porter (:squib)]

I'd like to suggest that we mark this bug WONTFIX, and that we should just open most web pages in the user's default browser. There's just no way we'll be able to make Thunderbird into a good (or even usable) browser; look at all the work the Firefox team has to do. Even if we found someone to work on this, it'd be quite a bit of code that we'd have to maintain.

Comment 15

[Jim Porter (:squib)]

Mike: thoughts on comment 14?

Comment 16

[Mike Conley (:mconley) (:⚙️)]

Yep, sounds good.