661879 - [fennec][spanish]Pop up notification gets truncated in portrait view.

Status: RESOLVED WORKSFORME

(Mozilla Localizations :: es-ES / Spanish, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Mozilla/5.0 (Android; Linux armv71; rv5.0) Gecko/20110527 Firefox/5.0 Fennec/5.0
Device: Thunderbolt
OS: Android 2.2

1. set device to portrait
2. set device to spanish
3. go to http://popuptest.com/popuptest1.html.

Expected: the notification fits to page.
Actual: the notification gets truncated

Note: doesn't happen with geo location and offline storage.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

Comment 2

[Guillermo López :willyaranda (probably SLOW response)]

Ricardo, what do you think about:

"Mostrar", "Siempre", "Nunca"?

Comment 3

[RickieES aka Ricardo Palomares]

Asking me works better if I'm in CC. ;-)

I've been thinking about other options that could be clearer (mainly, "Mostrar", "Mostrar siempre", "M. nunca" & "Mostrar", "M. siempre", "M. nunca") but I don't like the visual aspect of the second option, and I strongly doubt the first wouldn't overflow too.

So, yes, I think your proposal is the best one.

Comment 4

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: Patch for mozilla-central

Sorry, Ricardo ;)

Axel, one question, we need to push this patch in central, aurora and beta. What is the best way to push this patch for all the repos for the future central-aurora manual merge?

Thanks!

Comment 5

[Axel Hecht [:Pike]]

The best way is to land on beta, and then merge to aurora, and that to central.

Comment 6

[Guillermo López :willyaranda (probably SLOW response)]

(Waiting for bug 661889 to be answered)

Comment 7

[RickieES aka Ricardo Palomares]

Again, this will need to travel back. Let's see what happens to our aurora repo in some minutes.

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 537899 [details] [diff] [review]
Patch for mozilla-central

Clearing the feedback request, not that I can do anything for that.

To clarify, there was nothing that happened to your aurora repos, we just auto-updated the beta ones.

Comment 9

[Guillermo López :willyaranda (probably SLOW response)]

This has been fixed in aurora and central.