Closed
Bug 662107
Opened 13 years ago
Closed 13 years ago
Switch PageInfo to use Services.jsm
Categories
(SeaMonkey :: Page Info, defect)
SeaMonkey
Page Info
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.4
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(1 file)
|
18.36 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
Pageinfo could make use of Services.jsm allowing some code tidy up. This patch does that.
Attachment #537396 -
Flags: review?(neil)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 537396 [details] [diff] [review] Switch to Services.jsm [Checked in: Comment 2] >-const ALLOW = nsIPermissionManager.ALLOW_ACTION; // 1 >-const BLOCK = nsIPermissionManager.DENY_ACTION; // 2 >+const ALLOW = Services.perms.ALLOW_ACTION; // 1 >+const BLOCK = Services.perms.DENY_ACTION; // 2 > const SESSION = nsICookiePermission.ACCESS_SESSION;// 8 Nit: need to make the comments line up again
Attachment #537396 -
Flags: review?(neil) → review+
Comment on attachment 537396 [details] [diff] [review] Switch to Services.jsm [Checked in: Comment 2] Checked in with lining up of comments and removal of Services.jsm import as it is already imported by utilityOverlay.js http://hg.mozilla.org/comm-central/rev/c2dc4fb6d8e4
Attachment #537396 -
Attachment description: Switch to Services.jsm → Switch to Services.jsm [Checked in: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.4
You need to log in
before you can comment on or make changes to this bug.
Description
•