Last Comment Bug 662125 - nsDocShell::ConfirmRepost passes uninitialized PRBool as inout param to nsIPrompt::ConfirmEx
: nsDocShell::ConfirmRepost passes uninitialized PRBool as inout param to nsIPr...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Document Navigation (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla7
Assigned To: Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
:
:
Mentors:
Depends on:
Blocks: 658351 662126
  Show dependency treegraph
 
Reported: 2011-06-04 22:29 PDT by Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
Modified: 2011-06-06 11:01 PDT (History)
0 users
khuey: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (910 bytes, patch)
2011-06-04 22:31 PDT, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
bzbarsky: review+
Details | Diff | Splinter Review

Description Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-06-04 22:29:02 PDT
I think this also implies that this isn't covered by tests ...
Comment 1 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-06-04 22:31:05 PDT
Created attachment 537421 [details] [diff] [review]
Patch
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2011-06-06 10:49:30 PDT
Comment on attachment 537421 [details] [diff] [review]
Patch

Add a comment indicating the value doesn't actually matter, and r=me.

And yes, this is probably not covered by tests...
Comment 3 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-06-06 11:01:53 PDT
http://hg.mozilla.org/mozilla-central/rev/b69d30cc0b24

I'll try to write a test for this as time permits.

Note You need to log in before you can comment on or make changes to this bug.