"Deactivate this device" doesn't update UI instantly on slow internet connections

VERIFIED FIXED in Firefox 5

Status

Cloud Services
Firefox Sync: Backend
VERIFIED FIXED
6 years ago
3 years ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

({regression, verified-aurora, verified-beta})

unspecified
mozilla7
regression, verified-aurora, verified-beta
Points:
---

Firefox Tracking Flags

(firefox5 fixed, firefox6 fixed)

Details

(Whiteboard: [verified in services])

Attachments

(1 attachment)

This is a regression from bug 565430: we now send requests to the server to clean up any client specific data, but we wait for those requests to come through to clear anything else, including the UI. That means with a laggy internet connection the UI doesn't update instantly and the user is perplexed (I was!).

We should send the appropriate notifications at the top of Service.startOver() so that the UI is updated instantly.
Created attachment 537480 [details] [diff] [review]
v1
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #537480 - Flags: review?(rnewman)
(Assignee)

Updated

6 years ago
OS: Mac OS X → All
Hardware: x86 → All
Comment on attachment 537480 [details] [diff] [review]
v1

Looks good to me!
Attachment #537480 - Flags: review?(rnewman) → review+
(Assignee)

Updated

6 years ago
tracking-firefox5: --- → ?
(Assignee)

Updated

6 years ago
Attachment #537480 - Flags: approval-mozilla-beta?
Attachment #537480 - Flags: approval-mozilla-aurora?
Justification for approval: bug 565430 introduced a regression and the patch is pretty low risk.
http://hg.mozilla.org/services/services-central/rev/874ac197d206
Whiteboard: [fixed in services]

Comment 5

6 years ago
(In reply to comment #4)
> http://hg.mozilla.org/services/services-central/rev/874ac197d206

This doesn't look to be the patch in this bug...was this actually fixed or was this bug marked by mistake?

Comment 6

6 years ago
Comment on attachment 537480 [details] [diff] [review]
v1

Please land this ASAP, and as long as you are confident enough in the patch for it to be in a RC build.
Attachment #537480 - Flags: approval-mozilla-beta?
Attachment #537480 - Flags: approval-mozilla-beta+
Attachment #537480 - Flags: approval-mozilla-aurora?
Attachment #537480 - Flags: approval-mozilla-aurora+

Comment 7

6 years ago
(In reply to comment #6)
> Comment on attachment 537480 [details] [diff] [review] [review]
> v1
> 
> Please land this ASAP, and as long as you are confident enough in the patch
> for it to be in a RC build.

To be more specific, we need this in by tomorrow, 2011-06-07 @ 2:00 pm PDT for mozilla-beta.
(In reply to comment #5)
> (In reply to comment #4)
> > http://hg.mozilla.org/services/services-central/rev/874ac197d206
> 
> This doesn't look to be the patch in this bug...was this actually fixed or
> was this bug marked by mistake?

Looks like it should be

http://hg.mozilla.org/services/services-central/rev/695a05d90784
874ac was the parent of that changeset; I think Philipp just copied the wrong one. If he doesn't respond to my IRC ping soonish, I'll go ahead and land this on Aurora.

Christian, does this need to land anywhere else for it to satisfy the requested flags? Not sure of the process.

Comment 10

6 years ago
We granted approval on releases/mozilla-beta as well, please land there too.
Transplanted to Aurora:

http://hg.mozilla.org/releases/mozilla-aurora/rev/8647efd8e1c7
I'm about half-way done with the beta transplant (just wrestling hg). Will finish after I take the dog for a walk.
Transplanted to mozilla-beta:

http://hg.mozilla.org/releases/mozilla-beta/rev/9d2108905529

(Carries with it the clusterURL check that didn't make it to beta yet. That's super, super safe, so I included it.)

I have set status-firefox[56] to "fixed", which I understand to be the correct action. Please change that and enlighten me if I'm wrong! 

The only place this now isn't is mozilla-central. When we land this, or merge s-c after QA, we'll resolve this bug.
status-firefox5: --- → fixed
status-firefox6: --- → fixed
... and a bustage fix on mozilla-beta. I am ashamed.

http://hg.mozilla.org/releases/mozilla-beta/rev/065b5f7e37c1
Verified in aurora nightly of 20110607.  will verify in beta when it's built next and in s-c on next train there.

Comment 16

6 years ago
not going to continue tracking for 5.
tracking-firefox5: ? → ---
Need testing on Fennec for beta and aurora branch also.
verified with latest s-c builds
Whiteboard: [fixed in services] → [fixed in services][verified in services]
(In reply to comment #17)
> Need testing on Fennec for beta and aurora branch also.

Verified on fennec for aurora and beta branches.

Mozilla/5.0 (Android; Linux armv71; rv:6.0a2) Gecko/20110613 Firefox/6.0a2 Fennec/6.0a2
Mozilla/5.0 (Android; Linux armv71; rv:5.0) Gecko/20110613 Firefox/5.0 Fennec/5.0
Keywords: verified-aurora, verified-beta
http://hg.mozilla.org/mozilla-central/rev/695a05d90784
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services][verified in services] → [verified in services]
Target Milestone: --- → mozilla7

Updated

6 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.