662200 - nsISHistory::requestedIndex is not reset after page reload through nsSHistory::Reload

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Start on page A, navigate to page B, then page C.  Click back.  Refresh (what is now page B).  The navigation buttons will be greyed out when they should not be.

Comment 1

[Justin Lebar (not reading bugmail)]

I couldn't reproduce on a few sites I tried.  Can you try a more detailed str?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Are you trying a build with the patch from bug 622315?

Comment 3

[Justin Lebar (not reading bugmail)]

Ah, nope.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yeah, this is a regression from that.  I backed it out since I didn't have any clue how to fix this.

Comment 5

[Boris Zbarsky [:bzbarsky]]

So the issue, presumably, is that nothing actually resets the requested index when the navigation completes?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Should we be comparing requested index to current index as well, not just to -1?

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

This fixes this behavior for me and passes the tests in docshell/

I'm going to try to write a mochitest for this behavior.

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to comment #5)
> So the issue, presumably, is that nothing actually resets the requested
> index when the navigation completes?

Yes, this is correct.  The attached patch does that.

(In reply to comment #6)
> Should we be comparing requested index to current index as well, not just to
> -1?

I don't think so.  I think we should avoid navigating whenever there is a pending navigation.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 537785 [details] [diff] [review]
Patch

Hrm...  Changing this stuff is scary as hell, but ok...

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yeah, I'm terrified too :-)

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

So, fun thing, this only occurs if the reload is triggered through nsSHistory.  If the reload goes through nsDocShell we do an internal load and never muck with history.

Comment 12

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Patch:

http://hg.mozilla.org/projects/cedar/rev/580ddd2f1267

Regression test:

http://hg.mozilla.org/projects/cedar/rev/ea5ed0f2a952

Comment 13

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/580ddd2f1267
http://hg.mozilla.org/mozilla-central/rev/ea5ed0f2a952

Comment 14

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This was backed out of Aurora to fix Bug 670318.

http://hg.mozilla.org/releases/mozilla-aurora/rev/cd5b516e9a39
http://hg.mozilla.org/releases/mozilla-aurora/rev/5cf936e830cf