Start on page A, navigate to page B, then page C. Click back. Refresh (what is now page B). The navigation buttons will be greyed out when they should not be.
I couldn't reproduce on a few sites I tried. Can you try a more detailed str?
Are you trying a build with the patch from bug 622315?
Yeah, this is a regression from that. I backed it out since I didn't have any clue how to fix this.
So the issue, presumably, is that nothing actually resets the requested index when the navigation completes?
Should we be comparing requested index to current index as well, not just to -1?
Created attachment 537785 [details] [diff] [review] Patch This fixes this behavior for me and passes the tests in docshell/ I'm going to try to write a mochitest for this behavior.
(In reply to comment #5) > So the issue, presumably, is that nothing actually resets the requested > index when the navigation completes? Yes, this is correct. The attached patch does that. (In reply to comment #6) > Should we be comparing requested index to current index as well, not just to > -1? I don't think so. I think we should avoid navigating whenever there is a pending navigation.
6 years ago
Comment on attachment 537785 [details] [diff] [review] Patch Hrm... Changing this stuff is scary as hell, but ok...
Yeah, I'm terrified too :-)
So, fun thing, this only occurs if the reload is triggered through nsSHistory. If the reload goes through nsDocShell we do an internal load and never muck with history.
Patch: http://hg.mozilla.org/projects/cedar/rev/580ddd2f1267 Regression test: http://hg.mozilla.org/projects/cedar/rev/ea5ed0f2a952
This was backed out of Aurora to fix Bug 670318. http://hg.mozilla.org/releases/mozilla-aurora/rev/cd5b516e9a39 http://hg.mozilla.org/releases/mozilla-aurora/rev/5cf936e830cf