662416 - test_something currently doesnt work

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

https://github.com/mozautomation/mozmill/tree/master/mutt/mutt/tests/js/test_something

(mozmill)│mozmill -t test_something/
Xlib:  extension "GLX" missing on display ":0.0".
TEST-START |
/home/jhammel/mozmill/src/mozmill/mutt/mutt/tests/js/test_something/test_parents.js
| setupModule
TEST-START |
/home/jhammel/mozmill/src/mozmill/mutt/mutt/tests/js/test_something/test_parents.js
| testInParent
TEST-PASS |
/home/jhammel/mozmill/src/mozmill/mutt/mutt/tests/js/test_something/test_parents.js
| testInParent
TEST-START |
/home/jhammel/mozmill/src/mozmill/mutt/mutt/tests/js/test_something/test_sub/test_deps.js
| setupModule
TEST-START |
/home/jhammel/mozmill/src/mozmill/mutt/mutt/tests/js/test_something/test_sub/test_deps.js
| testDependencies
ERROR | Test Failure: {"exception": {"stack":
"()@resource://mozmill/modules/frame.js ->
file:///home/jhammel/mozmill/src/mozmill/mutt/mutt/tests/js/test_something/test_sub/test_deps.js:12\n((function
() {jum.assertEquals(test_parent.asdf,
\"asdf\");}))@resource://mozmill/modules/frame.js:496\n([object
Object])@resource://mozmill/modules/frame.js:550\n(\"/home/jhammel/mozmill/src/mozmill/mutt/mutt/tests/js/test_something/test_sub/test_deps.js\",null)@resource://mozmill/modules/frame.js:460\n(\"/home/jhammel/mozmill/src/mozmill/mutt/mutt/tests/js/test_something/test_sub/test_deps.js\",false,null)@resource://mozmill/modules/frame.js:585\n((function
(filename, invokedFromIDE, name) {var runner = new Runner(new
Collector, invokedFromIDE);runner.runTestFile(filename,
name);runner.end();return true;}),[object
Proxy])@resource://jsbridge/modules/bridge.js:135\n(\"0a5fc2ba-9088-11e0-95db-00262df16844\",(function
(filename, invokedFromIDE, name) {var runner = new Runner(new
Collector, invokedFromIDE);runner.runTestFile(filename,
name);runner.end();return true;}),[object
Proxy])@resource://jsbridge/modules/bridge.js:139\n@:0\n", "message":
"test_parent is not defined", "fileName":
"resource://mozmill/modules/frame.js ->
file:///home/jhammel/mozmill/src/mozmill/mutt/mutt/tests/js/test_something/test_sub/test_deps.js",
"name": "ReferenceError", "lineNumber": 12}}
TEST-UNEXPECTED-FAIL |
/home/jhammel/mozmill/src/mozmill/mutt/mutt/tests/js/test_something/test_sub/test_deps.js
| testDependencies
INFO | DEBUG::Calling wait for finish now
INFO | 
ERROR | Wait timed out, attempting kill
ERROR | 
INFO | DEBUG: stop is calling kill
INFO | 
INFO | Passed: 1
INFO | Failed: 1
INFO | Skipped: 0

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So, it's using the old module system. Not sure if we want to continue to support this in favor of having the securable modules in-place. I thought we wanted to remove that for Mozmill 2 but can't find a bug for it right now.

Clint, what do you think?

Comment 2

[cmtalbert]

Not blocking 2.0, we should probably remove the test from 2.0 so that it won't fail, but we don't need to pull out all the associated code from the 2.0 tree. A follow on bug would be good to remove the old code.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Remove Test (v1)

Pointer to Github pull-request

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 623969 [details] [diff] [review]
Remove Test (v1)

So lets get this test killed.

Comment 5

[Jeff Hammel]

Comment on attachment 623969 [details] [diff] [review]
Remove Test (v1)

looks good to me.  Thanks!

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
https://github.com/mozautomation/mozmill/commit/93719764616a88a096e9160b135b25c5cda32567