Closed Bug 662923 Opened 10 years ago Closed 6 years ago

Hovering over toolbarless app tab should show URL

Categories

(Firefox :: Tabbed Browser, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: jruderman, Assigned: Felipe)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Either show the URL in the tooltip (along with the page title), or temporarily show the address bar.
Attached patch Display URL in tooltips (obsolete) — Splinter Review
Displays the site URL in the tooltips for toolbarless app tabs.

Talked with Jesse if we should crop the URL or not.. The tooltip doesn't expand infinitely, and instead wraps reasonably well, so it seems it won't be necessary to crop them. I guess we can experiment and see

(I could just merge this in the main patch too, if wanted.. as it's a separate bug I made it in a separate patch)
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Attachment #539350 - Flags: review?(gavin.sharp)
a part of the patch was moved to the parent bug
Attachment #539350 - Attachment is obsolete: true
Attachment #539350 - Flags: review?(gavin.sharp)
Attachment #539374 - Flags: review?(gavin.sharp)
Comment on attachment 539374 [details] [diff] [review]
Display URL in tooltips

>+          if (window.ChromelessAppTabs && ChromelessAppTabs.shouldHideToolbars(tab)) {

This is obviously not accurate with regards to customizations. There's also no need for tabbrowser to know about "chromeless app tabs". What you really want here, I think, is check the visibility of the url bar.
Attachment #539374 - Flags: review?(gavin.sharp) → review-
This bug is marked to be blocking issue #649448.
But that issue can probably be resolved without depending on this issue. To me it seems that resolving issue #649448 would resolve this issue as well if we choose to show the URL on hovering a tab in any scenario (active/inactive/pinned app tab).
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.