Closed Bug 662946 Opened 9 years ago Closed 9 years ago

Remove a bunch of headers from INSTALLED_HEADERS, making changes necessary to do so

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: Waldo, Assigned: Waldo)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Attached patch PatchSplinter Review
Inspired by bug 662231, I went on a mini-rampage pruning INSTALLED_HEADERS by almost 20%.  Some of the entries in the list can be flat-out removed with no other changes.  Others need a little trimming in Mozilla code to remove them.  Others need (dead) callers to be killed in order to remove then-pointless inclusions.  Some need some forward-declares to avoid inclusions.  But anyway, all the removals here were pretty easy, and they required no deep surgery to disconnect XPConnect and jsobj.h or jsscope.h or jscntxt.h or anything similarly awful.  I'll leave that for other people and other times.

Try-building has not yet given this a stamp of approval:

http://tbpl.mozilla.org/?tree=Try&rev=32b4723ce26c

But a local build has, so I'm posting this in anticipation of being able to r? it shortly.
Attachment #538125 - Flags: review?(jimb)
Hi, Jeff. I'll be able to review this and your other patches on Monday, but for today I have some Debugger stuff I'm really hoping to wrap up before Jason gets back from vacation.
Comment on attachment 538125 [details] [diff] [review]
Patch

Review of attachment 538125 [details] [diff] [review]:
-----------------------------------------------------------------

r+, including parts I'm not a reviewer for, since it's dead code.
Attachment #538125 - Flags: review?(jimb) → review+
http://hg.mozilla.org/tracemonkey/rev/ce077af8195c
Whiteboard: fixed-in-tracemonkey
Target Milestone: --- → mozilla7
Note that the bug 615621 is probably related to this one.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.