663555 - AttributeError: 'NoneType' object has no attribute 'channel'

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect)

Description

[Wil Clouser [:clouserw]]

on preview: /usr/bin/python26 manage.py cron update_addons_collections_downloads


Traceback (most recent call last):
  File "manage.py", line 75, in <module>
    execute_manager(settings)
  File "/data/amo_python/src/preview/zamboni/vendor/src/django/django/core/management/__init__.py", line 438, in execute_manager
    utility.execute()
  File "/data/amo_python/src/preview/zamboni/vendor/src/django/django/core/management/__init__.py", line 379, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/data/amo_python/src/preview/zamboni/vendor/src/django/django/core/management/base.py", line 191, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/data/amo_python/src/preview/zamboni/vendor/src/django/django/core/management/base.py", line 220, in execute
    output = self.handle(*args, **options)
  File "/data/amo_python/src/preview/zamboni/vendor/src/django-cronjobs/cronjobs/management/commands/cron.py", line 64, in handle
    registered[script](*args)
  File "/data/amo_python/src/preview/zamboni/apps/stats/cron.py", line 28, in update_addons_collections_downloads
    args=[chunk], connection=conn)
  File "/data/amo_python/src/preview/zamboni/vendor/lib/python/celery/task/base.py", line 448, in apply_async
    exchange_type=exchange_type)
  File "/data/amo_python/src/preview/zamboni/vendor/lib/python/celery/task/base.py", line 301, in get_publisher
    **options)
  File "/data/amo_python/src/preview/zamboni/vendor/lib/python/celery/app/amqp.py", line 328, in TaskPublisher
    return TaskPublisher(*args, **self.app.merge(defaults, kwargs))
  File "/data/amo_python/src/preview/zamboni/vendor/lib/python/celery/app/amqp.py", line 156, in __init__
    super(TaskPublisher, self).__init__(*args, **kwargs)
  File "/data/amo_python/src/preview/zamboni/vendor/lib/python/kombu/compat.py", line 79, in __init__
    self.backend = connection.channel()
  File "/data/amo_python/src/preview/zamboni/vendor/lib/python/kombu/connection.py", line 124, in channel
    chan = self.transport.create_channel(self.connection)
  File "/data/amo_python/src/preview/zamboni/vendor/lib/python/kombu/transport/pyamqplib.py", line 220, in create_channel
    return connection.channel()
AttributeError: 'NoneType' object has no attribute 'channel'


Putting in 6.1.1 because I know you've been doing stuff with celery and I'm not sure if this is something that just broke or what.

Comment 1

[Jeff Balogh (:jbalogh)]

kombu is new in the celery upgrade so it's something I broke recently.

Comment 2

[Jeff Balogh (:jbalogh)]

http://groups.google.com/group/celery-users/browse_thread/thread/3405b2887a25c58d?pli=1
http://celeryproject.org/docs/userguide/executing.html#connections-and-connection-timeouts
http://celeryproject.org/docs/userguide/tasksets.html#sets-taskset
http://celeryproject.org/docs/reference/celery.task.sets.html#celery.task.sets.subtask

Conclusion: establish_connection() is no good, we should be using TaskSet instead.

Comment 3

[Jeff Balogh (:jbalogh)]

https://github.com/jbalogh/zamboni/commit/ba0a3a4