Closed Bug 663611 Opened 14 years ago Closed 13 years ago

display pointer cursor when hovering tab groups

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 8

People

(Reporter: ttaubert, Assigned: raymondlee)

References

Details

Attachments

(1 file, 2 obsolete files)

We want the default cursor when hovering tab groups. The move cursor should only be shown when hovering the groups' titlebars. https://wiki.mozilla.org/Simplify_Panorama_UI
Summary: change cursor when hovering tab groups → display default cursor when hovering tab groups
Attached patch v1 (obsolete) — Splinter Review
trivial patch
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #538813 - Flags: feedback?(tim.taubert)
Attachment #538813 - Attachment is patch: true
Depends on: 663612
Summary: display default cursor when hovering tab groups → display pointer cursor when hovering tab groups
Comment on attachment 538813 [details] [diff] [review] v1 Review of attachment 538813 [details] [diff] [review]: ----------------------------------------------------------------- Sorry, I actually meant "pointer" cursor on the group body and the "move" cursor on the title bar. So we indicate that you can zoom into the group when hovering it.
Attachment #538813 - Flags: feedback?(tim.taubert)
Attached patch v2 (obsolete) — Splinter Review
Attachment #538813 - Attachment is obsolete: true
Attachment #538921 - Flags: feedback?(tim.taubert)
Comment on attachment 538921 [details] [diff] [review] v2 Review of attachment 538921 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #538921 - Flags: feedback?(tim.taubert) → feedback+
Attachment #538921 - Flags: review?(ian)
Comment on attachment 538921 [details] [diff] [review] v2 Review of attachment 538921 [details] [diff] [review]: ----------------------------------------------------------------- Why do we want this change?
Attachment #538921 - Flags: ui-review?(faaborg)
I assume limi was asking for it. I'm pretty sure I disagree though, the cursor change is important for discovering that the groups are moveable. Unless we draw a more discrete title bar for each group, I think this is the best way to balance people realizing that they can move them with the visually minimalist design.
(In reply to comment #6) > I assume limi was asking for it. I'm pretty sure I disagree though, the > cursor change is important for discovering that the groups are moveable. > Unless we draw a more discrete title bar for each group, I think this is the > best way to balance people realizing that they can move them with the > visually minimalist design. Yeah, it's part of https://wiki.mozilla.org/Improve_Panorama_interactions I think the reason for this was that the default action when clicking a group should now be to zoom into it (bug 663612) - which is advertised by the new cursor. The title bar still has the move cursor. I guess Limi has more details :)
Comment on attachment 538921 [details] [diff] [review] v2 tentative -, but cc'ing Limi
Attachment #538921 - Flags: ui-review?(faaborg) → ui-review-
Comment on attachment 538921 [details] [diff] [review] v2 Review of attachment 538921 [details] [diff] [review]: ----------------------------------------------------------------- I think I agree with faaborg. My reasoning is that it's nice to have a difference between the cursor for groups and the cursor for tabs.
Attachment #538921 - Flags: review?(ian) → review-
Comment on attachment 538921 [details] [diff] [review] v2 Review of attachment 538921 [details] [diff] [review]: ----------------------------------------------------------------- I guess if bug 663612 lands, then this should land as well. This patch doesn't make any sense without it. Seeing as how the dependency is set properly for that, changing my review to r+. That said, I don't agree bug 663612.
Attachment #538921 - Flags: review- → review+
Comment on attachment 538921 [details] [diff] [review] v2 This patch landed on ux-branch yesterday.
Attachment #538921 - Flags: ui-review- → ui-review?(faaborg)
Comment on attachment 538921 [details] [diff] [review] v2 Works great, thanks!
Attachment #538921 - Flags: ui-review?(faaborg) → ui-review+
Attachment #538921 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8
Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110907 Firefox/9.0a1 Verified fixed on Ubuntu 10.4, Mac OS 10.7, Windows 7 and XP. The pointer cursor is displayed on the group body and the move cursor is displayed on the group title bar, as specified in Comment 2.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: