663611 - display pointer cursor when hovering tab groups

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

We want the default cursor when hovering tab groups. The move cursor should only be shown when hovering the groups' titlebars.

https://wiki.mozilla.org/Simplify_Panorama_UI

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: v1

trivial patch

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 538813 [details] [diff] [review]
v1

Review of attachment 538813 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I actually meant "pointer" cursor on the group body and the "move" cursor on the title bar. So we indicate that you can zoom into the group when hovering it.

Comment 3

[Raymond Lee [:raymondlee]]

Attachment: v2

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 538921 [details] [diff] [review]
v2

Review of attachment 538921 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Ian Gilman [:iangilman]]

Comment on attachment 538921 [details] [diff] [review]
v2

Review of attachment 538921 [details] [diff] [review]:
-----------------------------------------------------------------

Why do we want this change?

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

I assume limi was asking for it.  I'm pretty sure I disagree though, the cursor change is important for discovering that the groups are moveable.  Unless we draw a more discrete title bar for each group, I think this is the best way to balance people realizing that they can move them with the visually minimalist design.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

(In reply to comment #6)
> I assume limi was asking for it.  I'm pretty sure I disagree though, the
> cursor change is important for discovering that the groups are moveable. 
> Unless we draw a more discrete title bar for each group, I think this is the
> best way to balance people realizing that they can move them with the
> visually minimalist design.

Yeah, it's part of https://wiki.mozilla.org/Improve_Panorama_interactions

I think the reason for this was that the default action when clicking a group should now be to zoom into it (bug 663612) - which is advertised by the new cursor. The title bar still has the move cursor. I guess Limi has more details :)

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 538921 [details] [diff] [review]
v2

tentative -, but cc'ing Limi

Comment 9

[Ian Gilman [:iangilman]]

Comment on attachment 538921 [details] [diff] [review]
v2

Review of attachment 538921 [details] [diff] [review]:
-----------------------------------------------------------------

I think I agree with faaborg. My reasoning is that it's nice to have a difference between the cursor for groups and the cursor for tabs.

Comment 10

[Ian Gilman [:iangilman]]

Comment on attachment 538921 [details] [diff] [review]
v2

Review of attachment 538921 [details] [diff] [review]:
-----------------------------------------------------------------

I guess if bug 663612 lands, then this should land as well. This patch doesn't make any sense without it. Seeing as how the dependency is set properly for that, changing my review to r+. 

That said, I don't agree bug 663612.

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 538921 [details] [diff] [review]
v2

This patch landed on ux-branch yesterday.

Comment 12

[Alex Limi (:limi) — Firefox UX Team]

Comment on attachment 538921 [details] [diff] [review]
v2

Works great, thanks!

Comment 13

[Raymond Lee [:raymondlee]]

Attachment: Patch for checkin

Comment 14

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/integration/fx-team/rev/e34f6f9a5a01

Comment 15

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/mozilla-central/rev/e34f6f9a5a01

Comment 16

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110907 Firefox/9.0a1

Verified fixed on Ubuntu 10.4, Mac OS 10.7, Windows 7 and XP.
The pointer cursor is displayed on the group body and the move cursor is displayed on the group title bar, as specified in Comment 2.