display pointer cursor when hovering tab groups

VERIFIED FIXED in Firefox 8

Status

Firefox Graveyard
Panorama
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: ttaubert, Assigned: raymondlee)

Tracking

Trunk
Firefox 8
Dependency tree / graph

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 years ago
We want the default cursor when hovering tab groups. The move cursor should only be shown when hovering the groups' titlebars.

https://wiki.mozilla.org/Simplify_Panorama_UI
(Reporter)

Updated

6 years ago
Summary: change cursor when hovering tab groups → display default cursor when hovering tab groups
(Assignee)

Comment 1

6 years ago
Created attachment 538813 [details] [diff] [review]
v1

trivial patch
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #538813 - Flags: feedback?(tim.taubert)
(Reporter)

Updated

6 years ago
Attachment #538813 - Attachment is patch: true
(Reporter)

Updated

6 years ago
Depends on: 663612
Summary: display default cursor when hovering tab groups → display pointer cursor when hovering tab groups
(Reporter)

Comment 2

6 years ago
Comment on attachment 538813 [details] [diff] [review]
v1

Review of attachment 538813 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I actually meant "pointer" cursor on the group body and the "move" cursor on the title bar. So we indicate that you can zoom into the group when hovering it.
Attachment #538813 - Flags: feedback?(tim.taubert)
(Assignee)

Comment 3

6 years ago
Created attachment 538921 [details] [diff] [review]
v2
Attachment #538813 - Attachment is obsolete: true
Attachment #538921 - Flags: feedback?(tim.taubert)
(Reporter)

Comment 4

6 years ago
Comment on attachment 538921 [details] [diff] [review]
v2

Review of attachment 538921 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #538921 - Flags: feedback?(tim.taubert) → feedback+
(Assignee)

Updated

6 years ago
Attachment #538921 - Flags: review?(ian)
Comment on attachment 538921 [details] [diff] [review]
v2

Review of attachment 538921 [details] [diff] [review]:
-----------------------------------------------------------------

Why do we want this change?
Attachment #538921 - Flags: ui-review?(faaborg)
I assume limi was asking for it.  I'm pretty sure I disagree though, the cursor change is important for discovering that the groups are moveable.  Unless we draw a more discrete title bar for each group, I think this is the best way to balance people realizing that they can move them with the visually minimalist design.
(Reporter)

Comment 7

6 years ago
(In reply to comment #6)
> I assume limi was asking for it.  I'm pretty sure I disagree though, the
> cursor change is important for discovering that the groups are moveable. 
> Unless we draw a more discrete title bar for each group, I think this is the
> best way to balance people realizing that they can move them with the
> visually minimalist design.

Yeah, it's part of https://wiki.mozilla.org/Improve_Panorama_interactions

I think the reason for this was that the default action when clicking a group should now be to zoom into it (bug 663612) - which is advertised by the new cursor. The title bar still has the move cursor. I guess Limi has more details :)
Comment on attachment 538921 [details] [diff] [review]
v2

tentative -, but cc'ing Limi
Attachment #538921 - Flags: ui-review?(faaborg) → ui-review-
Comment on attachment 538921 [details] [diff] [review]
v2

Review of attachment 538921 [details] [diff] [review]:
-----------------------------------------------------------------

I think I agree with faaborg. My reasoning is that it's nice to have a difference between the cursor for groups and the cursor for tabs.
Attachment #538921 - Flags: review?(ian) → review-
Comment on attachment 538921 [details] [diff] [review]
v2

Review of attachment 538921 [details] [diff] [review]:
-----------------------------------------------------------------

I guess if bug 663612 lands, then this should land as well. This patch doesn't make any sense without it. Seeing as how the dependency is set properly for that, changing my review to r+. 

That said, I don't agree bug 663612.
Attachment #538921 - Flags: review- → review+
(Reporter)

Comment 11

6 years ago
Comment on attachment 538921 [details] [diff] [review]
v2

This patch landed on ux-branch yesterday.
Attachment #538921 - Flags: ui-review- → ui-review?(faaborg)
Comment on attachment 538921 [details] [diff] [review]
v2

Works great, thanks!
Attachment #538921 - Flags: ui-review?(faaborg) → ui-review+
(Assignee)

Comment 13

6 years ago
Created attachment 543564 [details] [diff] [review]
Patch for checkin
Attachment #538921 - Attachment is obsolete: true
(Reporter)

Comment 14

6 years ago
http://hg.mozilla.org/integration/fx-team/rev/e34f6f9a5a01
Whiteboard: [fixed-in-fx-team]
(Reporter)

Comment 15

6 years ago
http://hg.mozilla.org/mozilla-central/rev/e34f6f9a5a01
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8
Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110907 Firefox/9.0a1

Verified fixed on Ubuntu 10.4, Mac OS 10.7, Windows 7 and XP.
The pointer cursor is displayed on the group body and the move cursor is displayed on the group title bar, as specified in Comment 2.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.