Closed Bug 663630 Opened 9 years ago Closed 9 years ago

Remove unused places UI perf tests

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 7

People

(Reporter: dao, Assigned: dao)

References

Details

(Whiteboard: [fixed-in-places])

Attachments

(2 files, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
No description provided.
Attachment #538700 - Flags: review?(mak77)
I don't think we even look at these, so we could probably nuke them.
perf_large_delete.xul too?
(In reply to comment #2)
> perf_large_delete.xul too?
Check with mak, but I'd lean to yes at this point.
Attached patch rmSplinter Review
Attachment #538841 - Flags: review?(mak77)
Comment on attachment 538841 [details] [diff] [review]
rm

Yes, I was initially against removing these tests because we didn't have enough other tests leveraging that UI stuff, but now all that stuff is touched elsewhere, so it's ok to kill the tests folder.
Attachment #538841 - Flags: review?(mak77) → review+
Attachment #538700 - Attachment is obsolete: true
Attachment #538700 - Flags: review?(mak77)
Summary: Provide head.js for places UI perf tests → Remove places UI perf tests
I'll land this on Places shortly.
Summary: Remove places UI perf tests → Remove unused places UI perf tests
http://hg.mozilla.org/mozilla-central/rev/5378269494af
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
 Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110627 Firefox/7.0a1

Verified that folder was removed from the repository. 

Set status to Verified Fixed.
Status: RESOLVED → VERIFIED
Now we get this buildspam:
> can't read browser/components/places/tests/perf/Makefile.in: No such file or directory

This bug was missing an update to browser/makefiles.sh (which references that now-deleted makefile)
This fixes the buildspam noted in the previous comment.
Attachment #545208 - Flags: review?(mak77)
Comment on attachment 545208 [details] [diff] [review]
followup: fix makefiles.sh

Review of attachment 545208 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #545208 - Flags: review?(mak77) → review+
You need to log in before you can comment on or make changes to this bug.