Closed
Bug 663630
Opened 14 years ago
Closed 14 years ago
Remove unused places UI perf tests
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 7
People
(Reporter: dao, Assigned: dao)
References
Details
(Whiteboard: [fixed-in-places])
Attachments
(2 files, 1 obsolete file)
|
44.74 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
|
1.07 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #538700 -
Flags: review?(mak77)
|
||
Comment 1•14 years ago
|
||
I don't think we even look at these, so we could probably nuke them.
|
Assignee | |
Comment 2•14 years ago
|
||
perf_large_delete.xul too?
|
|
||
Comment 3•14 years ago
|
||
(In reply to comment #2)
> perf_large_delete.xul too?
Check with mak, but I'd lean to yes at this point.
|
|
Assignee | |
Comment 4•14 years ago
|
||
Attachment #538841 -
Flags: review?(mak77)
|
||
Comment 5•14 years ago
|
||
Comment on attachment 538841 [details] [diff] [review]
rm
Yes, I was initially against removing these tests because we didn't have enough other tests leveraging that UI stuff, but now all that stuff is touched elsewhere, so it's ok to kill the tests folder.
Attachment #538841 -
Flags: review?(mak77) → review+
|
|
||
Updated•14 years ago
|
Attachment #538700 -
Attachment is obsolete: true
Attachment #538700 -
Flags: review?(mak77)
|
|
Assignee | |
Updated•14 years ago
|
Summary: Provide head.js for places UI perf tests → Remove places UI perf tests
|
|
||
Comment 6•14 years ago
|
||
I'll land this on Places shortly.
|
|
||
Updated•14 years ago
|
Summary: Remove places UI perf tests → Remove unused places UI perf tests
|
|
||
Comment 7•14 years ago
|
||
Whiteboard: [fixed-in-places]
|
|
||
Comment 8•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
|
||
Comment 9•14 years ago
|
||
Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110627 Firefox/7.0a1
Verified that folder was removed from the repository.
Set status to Verified Fixed.
Status: RESOLVED → VERIFIED
|
||
Comment 10•14 years ago
|
||
Now we get this buildspam:
> can't read browser/components/places/tests/perf/Makefile.in: No such file or directory
This bug was missing an update to browser/makefiles.sh (which references that now-deleted makefile)
|
|
||
Comment 11•14 years ago
|
||
This fixes the buildspam noted in the previous comment.
Attachment #545208 -
Flags: review?(mak77)
|
|
||
Comment 12•14 years ago
|
||
Comment on attachment 545208 [details] [diff] [review]
followup: fix makefiles.sh
Review of attachment 545208 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #545208 -
Flags: review?(mak77) → review+
|
|
||
Comment 13•14 years ago
|
||
Landed followup on m-i:
http://hg.mozilla.org/integration/mozilla-inbound/rev/64c70dce2ee7
You need to log in
before you can comment on or make changes to this bug.
Description
•