Remove unused places UI perf tests

VERIFIED FIXED in Firefox 7

Status

()

Firefox
Bookmarks & History
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-places])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 538700 [details] [diff] [review]
patch
Attachment #538700 - Flags: review?(mak77)
I don't think we even look at these, so we could probably nuke them.
(Assignee)

Comment 2

6 years ago
perf_large_delete.xul too?
(In reply to comment #2)
> perf_large_delete.xul too?
Check with mak, but I'd lean to yes at this point.
(Assignee)

Comment 4

6 years ago
Created attachment 538841 [details] [diff] [review]
rm
Attachment #538841 - Flags: review?(mak77)
Comment on attachment 538841 [details] [diff] [review]
rm

Yes, I was initially against removing these tests because we didn't have enough other tests leveraging that UI stuff, but now all that stuff is touched elsewhere, so it's ok to kill the tests folder.
Attachment #538841 - Flags: review?(mak77) → review+

Updated

6 years ago
Attachment #538700 - Attachment is obsolete: true
Attachment #538700 - Flags: review?(mak77)
(Assignee)

Updated

6 years ago
Summary: Provide head.js for places UI perf tests → Remove places UI perf tests
I'll land this on Places shortly.

Updated

6 years ago
Summary: Remove places UI perf tests → Remove unused places UI perf tests
http://hg.mozilla.org/projects/places/rev/5378269494af
Whiteboard: [fixed-in-places]
http://hg.mozilla.org/mozilla-central/rev/5378269494af
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7

Comment 9

6 years ago
 Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110627 Firefox/7.0a1

Verified that folder was removed from the repository. 

Set status to Verified Fixed.
Status: RESOLVED → VERIFIED
Now we get this buildspam:
> can't read browser/components/places/tests/perf/Makefile.in: No such file or directory

This bug was missing an update to browser/makefiles.sh (which references that now-deleted makefile)
Created attachment 545208 [details] [diff] [review]
followup: fix makefiles.sh

This fixes the buildspam noted in the previous comment.
Attachment #545208 - Flags: review?(mak77)
Comment on attachment 545208 [details] [diff] [review]
followup: fix makefiles.sh

Review of attachment 545208 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #545208 - Flags: review?(mak77) → review+
Landed followup on m-i:
 http://hg.mozilla.org/integration/mozilla-inbound/rev/64c70dce2ee7
http://hg.mozilla.org/mozilla-central/rev/64c70dce2ee7
Blocks: 726491
Blocks: 636551
You need to log in before you can comment on or make changes to this bug.