726491 - Port |Bug 663630 - Remove unused places UI perf tests| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect, P4)

Description

[Serge Gautherie (:sgautherie)]

I was looking into trying to update perf_large_delete.xul as an additional part of bug 725549, when I noticed these FF removals.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Port |Bug 663630 - Remove unused places UI perf tests| to SeaMonkey [Checked in: Comment 3]

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 596539 [details] [diff] [review]
(Av1) Port |Bug 663630 - Remove unused places UI perf tests| to SeaMonkey
[Checked in: Comment 3]

Review of attachment 596539 [details] [diff] [review]:
-----------------------------------------------------------------

Please try to state a reason in the future. The mere fact that the FF guys remove something doesn't mean that it makes sense for us, too.

In this case I don't think we're losing much if we remove performance tests, especially if it potentially eases future updates to other tests because we won't have to care about side-effects on these to-be removed ones anymore.

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 596539 [details] [diff] [review]
(Av1) Port |Bug 663630 - Remove unused places UI perf tests| to SeaMonkey
[Checked in: Comment 3]

http://hg.mozilla.org/comm-central/rev/465ce21de933

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #2)
> In this case I don't think we're losing much if we remove performance tests,
> especially if it potentially eases future updates to other tests because we
> won't have to care about side-effects on these to-be removed ones anymore.

Fwiw, that is what I implied in my comment 0 :-|