663796 - unittests not being run on build-system branch

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[(not currently active) Ted Mielczarek]

We had unittests before, but the last few pushes seem to be missing them.

This push has tests:
http://hg.mozilla.org/projects/build-system/pushloghtml?changeset=d12dda590f4a
Fri Jun 10 10:43:24 2011 -0700

This push is missing tests:
http://hg.mozilla.org/projects/build-system/pushloghtml?changeset=055e5a11a673
Sat Jun 11 08:08:00 2011 -0700

Comment 1

[[e-mail] (:bhearsum)]

sendchanges are being sent, but they look a little funny:
python /builds/slave/bld-system-lnx/tools/buildfarm/utils/retry.py -s 5 -t 1800 -r 5 --stdout-regexp 'change sent successfully' buildbot sendchange --master production-master01.build.mozilla.org:9009 --username sendchange-unittest --branch build-system-linux-opt-unittest --revision 2f965cea44ffa1832336410f2c23d161b1173b8c --property buildid:20110612052844 --property builduid:3c73c407b78b420bbe55f8a423f4fcf6 http://stage.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/build-system-linux/1307881724/jsshell-linux-i686.zip http://stage.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/build-system-linux/1307881724/firefox-7.0a1.en-US.linux-i686.tests.zip

the "jsshell" part is suspicious, though I'd expect burning instead of absent tests if that were the issue. Then again, the first changeset with missing tests is https://bugzilla.mozilla.org/show_bug.cgi?id=543463

Comment 2

[David Humphrey (:humph)]

I think this is fixed by my patch landing in bug 543463 comment 34, since that will stop the executable being overwritten by jsshell in packageURL.

Comment 3

[(not currently active) Ted Mielczarek]

I backed those patches out of m-c in the interim so as to not leave it broken.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

I'm taking this since I'm on buildduty this week so I remember to close it after the next reconfig.