Closed Bug 663971 Opened 13 years ago Closed 13 years ago

Account wizard no longer looks at MX entries

Categories

(Thunderbird :: Account Manager, defect)

Product:
Thunderbird
Component:
Account Manager
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(blocking-thunderbird5.0 beta2+, thunderbird5.0 beta2-fixed, thunderbird6 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 7.0
Tracking Flags:
Tracking Status
blocking-thunderbird5.0 --- beta2+
thunderbird5.0 --- beta2-fixed
thunderbird6 --- fixed

People

(Reporter: rain1, Assigned: rain1)

References

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

actual patch
1.89 KB, patch
BenB
: review+
standard8
: approval-comm-aurora+
standard8
: approval-thunderbird5.0+
Details | Diff | Splinter Review
Seems like we lost the MX feature during the big rewrite in bug 549045.
This might need to block Miramar, I'm not sure.
blocking-thunderbird5.0: --- → ?
URGS!! Confirmed :-(
This is a must-fix. This would severely regress our hit rate and therefore setup usability. The fix is obvious and simple, just adding the function call.
Attached patch patch w/o test v1 (obsolete) — — Splinter Review
Right, this just adds back the call. I've reused the db string, as things were in <http://mxr.mozilla.org/comm-1.9.2/source/mailnews/base/prefs/content/accountcreation/emailWizard.js#513>.
Assignee: nobody → sid.bugzilla
Status: NEW → ASSIGNED
Attachment #539027 - Flags: review?(bwinton)
Attached patch actual patch — — Splinter Review
Have I mentioned how much I suck at hg?
Attachment #539027 - Attachment is obsolete: true
Attachment #539027 - Flags: review?(bwinton)
Attachment #539028 - Flags: review?(bwinton)
Attached patch Fix, v2 (obsolete) — — Splinter Review
Assignee: sid.bugzilla → ben.bucksch
Attachment #539028 - Attachment is obsolete: true
Attachment #539028 - Flags: review?(bwinton)
Attachment #539029 - Flags: review?(bwinton)
Sorry, I got too impatient.
Attachment #539029 - Attachment is obsolete: true
Attachment #539029 - Flags: review?(bwinton)
Comment on attachment 539028 [details] [diff] [review] actual patch r=BenB I tested my version of the patch, which is almost identical, and it works fine and fixes the bug. I tested with foo@google-analytics.com
Attachment #539028 - Attachment is obsolete: false
Attachment #539028 - Flags: review+
Assignee: ben.bucksch → sid.bugzilla
https://hg.mozilla.org/comm-central/rev/1cb7f969b6c0
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
Comment on attachment 539028 [details] [diff] [review] actual patch This is a pretty straightforward patch and fixes a regression.
Attachment #539028 - Flags: approval-thunderbird5.0?
Attachment #539028 - Flags: approval-comm-aurora?
Please approve this for 5.0, see comment 3.
Keywords: regression
Attachment #539028 - Flags: approval-thunderbird5.0? → approval-thunderbird5.0+
Ludo: I think we need some sort of litmus or other test case for this.
blocking-thunderbird5.0: ? → beta2+
Flags: in-litmus?(ludovic)
(In reply to comment #12) > Ludo: I think we need some sort of litmus or other test case for this. Agreed - and we need to make sure they get run.
This is a regression of bug 551519. Bug 551519 comment 31 has the litmus test, which was posted at <https://litmus.mozilla.org/show_test.cgi?id=11815>
Attachment #539028 - Flags: approval-comm-aurora? → approval-comm-aurora+
Thanks, Mark.
Flags: in-litmus?(ludovic)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: