664135 - on pressing return with an invalid input, GCLI should select the incorrect input for an easy fix

Status: RESOLVED WONTFIX

(DevTools :: Console, defect, P3)

Description

[Joe Walker [:jwalker]]

This has the problem that the habit of pressing return to get to the error is  dangerous, (also it requires a new API into Requisition)

Example implementation:

Inputter.prototype.onKeyUp = function(ev) {
    // RETURN does a special exec/highlight thing
    if (ev.keyCode === 13 /*RETURN*/) {
        var worst = this.requ.getStatus();
        // Deny RETURN unless the command might work
        if (worst === Status.VALID) {
            this.requ.exec();
            this.element.value = '';
        }
        else {
            var position = this.requ.getFirstNonValidPosition();
            dom.setSelectionStart(this.element, position.start);
            dom.setSelectionEnd(this.element, position.end);
        }

        this.update();
    }
    ...

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

I think it would be nice if a little "flash" message (similar to the help box) popped up and told the user that the command is unknown.

/my 2 cents

Comment 2

[Joe Walker [:jwalker]]

Moving GCLI bugs to Developer Tools: Console. Filter on 'baked beans are off'.

Comment 3

[Joe Walker [:jwalker]]

Triage. Filter on PEGASUS.

Comment 4

[Joe Walker [:jwalker]]

Overtaken by bug 773227.