Closed Bug 664135 Opened 11 years ago Closed 9 years ago

on pressing return with an invalid input, GCLI should select the incorrect input for an easy fix

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: jwalker, Unassigned)

Details

This has the problem that the habit of pressing return to get to the error is  dangerous, (also it requires a new API into Requisition)

Example implementation:

Inputter.prototype.onKeyUp = function(ev) {
    // RETURN does a special exec/highlight thing
    if (ev.keyCode === 13 /*RETURN*/) {
        var worst = this.requ.getStatus();
        // Deny RETURN unless the command might work
        if (worst === Status.VALID) {
            this.requ.exec();
            this.element.value = '';
        }
        else {
            var position = this.requ.getFirstNonValidPosition();
            dom.setSelectionStart(this.element, position.start);
            dom.setSelectionEnd(this.element, position.end);
        }

        this.update();
    }
    ...
Assignee: nobody → jwalker
Blocks: GCLI-FUTURE
I think it would be nice if a little "flash" message (similar to the help box) popped up and told the user that the command is unknown.

/my 2 cents
Assignee: jwalker → nobody
Moving GCLI bugs to Developer Tools: Console. Filter on 'baked beans are off'.
Component: Developer Tools → Developer Tools: Console
Triage. Filter on PEGASUS.
Priority: -- → P3
No longer blocks: GCLI-FUTURE
Overtaken by bug 773227.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.