Last Comment Bug 773227 - GCLI should open a help menu on enter for non-VALID (like pressing F1)
: GCLI should open a help menu on enter for non-VALID (like pressing F1)
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: Trunk
: All All
: P2 normal (vote)
: Firefox 17
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
:
Mentors:
Depends on:
Blocks: 779225
  Show dependency treegraph
 
Reported: 2012-07-12 04:29 PDT by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2012-08-25 17:08 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (37.65 KB, patch)
2012-08-03 06:43 PDT, Joe Walker [:jwalker] (needinfo me or ping on irc)
dcamp: review+
Details | Diff | Splinter Review

Description Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-12 04:29:33 PDT

    
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-08-03 06:31:46 PDT
We're actually doing it by simulating an error so that the help menu goes away when typing resumes.
Comment 2 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-08-03 06:43:27 PDT
Created attachment 648685 [details] [diff] [review]
v1

a.k.a https://github.com/campd/gcli/pull/58
Comment 3 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-08-03 07:33:24 PDT
This fix includes a fix for bug 779225
Comment 4 Dave Camp (:dcamp) 2012-08-25 17:08:48 PDT
https://hg.mozilla.org/mozilla-central/rev/4d6471c1cdd9

Note You need to log in before you can comment on or make changes to this bug.