664152 - move layout/base tests that depend heavily on enablePrivilege to mochitest-chrome

Status: RESOLVED WONTFIX

(Core :: DOM: Editor, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

there are 2 tests which are run from test_reftests_with_caret.html which make extensive use of enablePrivilege.  We can move these to mochitest chrome and run them inside of test_reftests_with_caret.html there.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: move layout/base/ tests that use a lot of enablePrivilege to chrome (1.0)

Comment 2

[(no longer active)]

Comment on attachment 539217 [details] [diff] [review]
move layout/base/ tests that use a lot of enablePrivilege to chrome (1.0)

Can you please move *all* of these tests to mochitest-chrome?  This will make it really hard to run both set of tests when I touch caret code.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: move layout/base/tests/test_reftest_with_caret.html and tests to chrome (1.0)

moved all the tests used by test_reftest_with_caret.html to chrome.  Tests are green on try as well

Comment 4

[(no longer active)]

Comment on attachment 540309 [details] [diff] [review]
move layout/base/tests/test_reftest_with_caret.html and tests to chrome (1.0)

Boy, do these renames suck!

> function runTests() {
>   try {
>     SimpleTest.waitForExplicitFinish();
>-
>     netscape.security.PrivilegeManager.enablePrivilege(
>-      'UniversalPreferencesRead UniversalPreferencesWrite UniversalXPConnect');
>+     'UniversalPreferencesRead UniversalPreferencesWrite UniversalXPConnect');

Hmm, can't we get rid of this too?  (If not, why is it needed?)

r=me with that removed.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/mozilla-central/rev/ae2dbbb7b935

Comment 6

[(no longer active)]

I had to back this patch out:

http://hg.mozilla.org/integration/mozilla-inbound/rev/65a94e646ad8

The problem is that here <http://hg.mozilla.org/mozilla-central/file/ae2dbbb7b935/layout/base/tests/chrome/bug613433-1.html#l17> we simulate a backspace key press.  In mochitest-chrome, this event bubbles up to the browser chrome, and triggers the back command, which means that the test is aborted prematurely, and we're losing test coverage with the patch as landed here.

I think the best option here is to use specialpowers APIs instead of moving the test to mochitest-chrome.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

originally the intention was to move just the two tests: 
bug585922.html
bug613807-1.html

we can move these, but we will have to duplicate test_reftest_with_caret.html which is sort of ugly.  Although we could be smarter about this.

Ideas?

Comment 8

[(no longer active)]

(In reply to comment #7)
> originally the intention was to move just the two tests: 
> bug585922.html
> bug613807-1.html
> 
> we can move these, but we will have to duplicate test_reftest_with_caret.html
> which is sort of ugly.  Although we could be smarter about this.
> 
> Ideas?

Can't we just add a SpecialPowers API to get the editor object from a text control and use that without moving the tests?

Comment 9

[(no longer active)]

Landed http://hg.mozilla.org/integration/mozilla-inbound/rev/d74a91fd10a8 as a followup to the backout.

Comment 10

[Marco Bonardo [:mak]]

merged the backout
http://hg.mozilla.org/mozilla-central/rev/65a94e646ad8
http://hg.mozilla.org/mozilla-central/rev/d74a91fd10a8

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

do we still wantto do this?  I am inclined to mark this as wontfix.

Comment 12

[(no longer active)]

Nope!