66435 - address book code leaks |DIR_Server|s

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When composing a message from a mailto: link, I saw a bunch of allocations
leaked that were allocated at:

PR_Calloc
dir_GetPrefsFrom45Branch(nsVoidArray **, nsVoidArray **)
DIR_GetServerPreferences(nsVoidArray **)
DIR_GetDirServers(void)
DIR_GetDirectories(void)
nsAbDirectory::GetDirList(void)

I'm guessing the problem is here:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/addrbook/src/nsDirPrefs.cpp&rev=1.42&mark=3245#3227

where you need to add an additional

else {
  DIR_DeleteServer(server);
}

for the case where obsoleteList is null and the allocated server doesn't get
added to either list.  (The observed leak could be from somewhere else, but
this code could certainly leak.)

Comment 1

[dprice (gone)]

anyone looking at this?  Can we get it fixed before .9?

Comment 2

[Håkan Waara]

Also, in that function, neither the nsVoidArray |obsoleteList| nor |list| are
freed. Am I right in this assumption, Chuang?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

They're returned to the caller.

Comment 4

[David :Bienvenu]

taking

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

I believe this might be a dup of bug 103193, as well.

Comment 6

[David :Bienvenu]

I think this is fixed - probably a dup, like you say.

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

With an updated CVS opt build under Purify, I no longer see this.

Verified FIXED.