Status

defect
RESOLVED WORKSFORME
8 years ago
3 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Posted patch patchSplinter Review
I'm not happy with this patch, but I'm not familiar with nsSessionStore.js
Feel free to fix the problem in nsSessionStore.js ;)
Attachment #539571 - Flags: review?(tim.taubert)
This very much sounds like it needs to be fixed in nsSessionStore.js.
Blocks: bc-leaks
(Assignee)

Comment 2

8 years ago
Dão, will bug 658738 fix this one too?
I hope it's the other way around: that fixing this bug kills some of the leaked windows logged in bug 658738.
Hm, I don't see how this patch would make the timer fire (or why it wouldn't fire in the first place) nor why it would keep things alive if it didn't fire.
(Assignee)

Comment 5

8 years ago
The patch just makes sure the timer has time to fire before the testing page
goes away.
Pure hack, but I'm not at all familiar what all nsSessionStore.js tries to
do and where it keeps references to which elements or windows.
It doesn't keep references... The timer firing after the page going away really shouldn't be a problem.
(Assignee)

Comment 7

8 years ago
Then I've misinterpret the code.
Somehow the timer in the patch in this bug makes the tests pass without leaking.
(Assignee)

Comment 8

8 years ago
And btw, the only leaking test, when parentNode is strong ref, is 
browser_tabview_firstrun_pref.js
We have _lots_ of windows opened and closed in tabview tests and it's not clear to me why only browser_tabview_firstrun_pref.js is leaking. I don't know why the setTimeout() fixes the leak but IMHO it doesn't look like the right solution.
(Assignee)

Comment 10

8 years ago
Comment on attachment 539571 [details] [diff] [review]
patch

Ok, someone (maybe me) needs to debug the leak some more.
Attachment #539571 - Flags: review?(tim.taubert)
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → WORKSFORME
No longer blocks: bc-leaks
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.