imageDataCb passed to Storage.getTabData in TabItem__reconnect runs when the tab is already gone

RESOLVED FIXED in Firefox 8

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: dao, Assigned: ttaubert)

Tracking

Trunk
Firefox 8
Dependency tree / graph

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Seen in browser-chrome test logs:

JavaScript Error: "self.tab is null" {file: "chrome://browser/content/tabview.js" line: 5178}
Blocks: 660175
Created attachment 544619 [details] [diff] [review]
patch v1

I'd like to have checked in ThumbnailStorage.loadThumbnail() whether the given tab is still linked to a TabItem before executing the callback but that's not possible as the tab might have been re-used be SS/SR in the meantime. So we need to check if the TabItem is still linked to a tab in TabItem._reconnect();
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Attachment #544619 - Flags: feedback?(raymond)
Attachment #544619 - Flags: feedback?(raymond) → feedback+
Attachment #544619 - Flags: review?(dao)
(Reporter)

Comment 2

6 years ago
Comment on attachment 544619 [details] [diff] [review]
patch v1

I don't think there's a point in checking tabData before self.tab.
Attachment #544619 - Flags: review?(dao) → review+
http://hg.mozilla.org/integration/fx-team/rev/3c57112a6a6f
Whiteboard: [fixed-in-fx-team]
http://hg.mozilla.org/mozilla-central/rev/3c57112a6a6f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8
(Reporter)

Updated

6 years ago
Duplicate of this bug: 670852
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.