Closed Bug 665023 Opened 13 years ago Closed 12 years ago

XPITriggerEvent::Run (nsXPITriggerInfo.cpp) should use NS_OK, not 0

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect)

Product:
Core Graveyard
Component:
Installer: XPInstall Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mounir, Assigned: mounir)

References

Details

(Whiteboard: [fixed by bug 652376])

Attachments

(1 file)

Trivial patch
2.78 KB, patch
Details | Diff | Splinter Review
Attached patch Trivial patch — — Splinter Review 
Basically, the patch is doing s/return 0;/return NS_OK;/. Looks like the method returns 0 even when failing but I'm not going to fix that in this patch (if it has to be fixed...).
Attachment #540073 - Flags: review?
Attachment #540073 - Flags: review? → review?(dveditz)
Comment on attachment 540073 [details] [diff] [review]
Trivial patch

This code isn't built and is due to be removed, no point wasting time on it
Attachment #540073 - Flags: review?(dveditz) → review-
Is there a bug tracking the removal of that code?
Whiteboard: [needs review]
Attachment #540073 - Flags: review-
(In reply to comment #2)
> Is there a bug tracking the removal of that code?

Bug 652376
Depends on: 652376
The dependent bug has now been fixed and the underlying code is gone. We should close this bug.
Indeed. Thanks for the reminder :)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 652376]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: