XPITriggerEvent::Run (nsXPITriggerInfo.cpp) should use NS_OK, not 0

RESOLVED FIXED

Status

Core Graveyard
Installer: XPInstall Engine
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed by bug 652376])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 540073 [details] [diff] [review]
Trivial patch

Basically, the patch is doing s/return 0;/return NS_OK;/. Looks like the method returns 0 even when failing but I'm not going to fix that in this patch (if it has to be fixed...).
Attachment #540073 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #540073 - Flags: review? → review?(dveditz)
Comment on attachment 540073 [details] [diff] [review]
Trivial patch

This code isn't built and is due to be removed, no point wasting time on it
Attachment #540073 - Flags: review?(dveditz) → review-
(Assignee)

Comment 2

6 years ago
Is there a bug tracking the removal of that code?
Whiteboard: [needs review]
(Assignee)

Updated

6 years ago
Attachment #540073 - Flags: review-
(In reply to comment #2)
> Is there a bug tracking the removal of that code?

Bug 652376
(Assignee)

Updated

6 years ago
Depends on: 652376

Comment 4

5 years ago
The dependent bug has now been fixed and the underlying code is gone. We should close this bug.
(Assignee)

Comment 5

5 years ago
Indeed. Thanks for the reminder :)
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 652376]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.