The default bug view has changed. See this FAQ.

Remove mozilla/xpinstall and move mozilla/toolkit/xpinstall to somewhere more sensible

RESOLVED FIXED in mozilla11

Status

Core Graveyard
Installer: XPInstall Engine
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: briansmith, Assigned: mossop)

Tracking

(Blocks: 1 bug)

Trunk
mozilla11
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [has patch][needs review dveditz])

Attachments

(3 attachments, 1 obsolete attachment)

Comment hidden (empty)
Summary: Remove mozilla/xpinstall and move mozilla/toolkit/xpinstall somewhere to more sensible → Remove mozilla/xpinstall and move mozilla/toolkit/xpinstall to somewhere more sensible
Be careful here, xpinstall/packager is most certainly not dead.
(Assignee)

Comment 2

6 years ago
Created attachment 528620 [details] [diff] [review]
move toolkit/mozapps/xpinstall

This moves the UI pieces from toolkit/mozapps/xpinstall into toolkit/mozapps/extensions. No point in having these separate really.
Attachment #528620 - Flags: review?(robert.bugzilla)
(Assignee)

Comment 3

6 years ago
Created attachment 528621 [details] [diff] [review]
move xpinstall/packager to toolkit/mozapps/installer

This moves the packaging code from xpinstall/packager to toolkit/mozapps/installer
Attachment #528621 - Flags: review?(robert.bugzilla)
(Assignee)

Comment 4

6 years ago
Created attachment 528622 [details] [diff] [review]
remove xpinstall

This removes the remains of xpinstall from the tree
Attachment #528622 - Flags: review?(robert.bugzilla)
(Assignee)

Comment 5

6 years ago
Comment on attachment 528622 [details] [diff] [review]
remove xpinstall

Dan, all this code is no longer in use so this just removes it from the tree
Attachment #528622 - Flags: review?(robert.bugzilla) → review?(dveditz)
(Assignee)

Updated

6 years ago
Whiteboard: [has patch][needs review rs][needs review dveditz]
Comment on attachment 528621 [details] [diff] [review]
move xpinstall/packager to toolkit/mozapps/installer

Let's get Kyle's review for the packager changes as well
Attachment #528621 - Flags: review?(khuey)
Whiteboard: [has patch][needs review rs][needs review dveditz] → [has patch][needs review rs][needs review dveditz][needs review khuey]
Comment on attachment 528621 [details] [diff] [review]
move xpinstall/packager to toolkit/mozapps/installer

Looks fine... still want khuey r+ before landing.
Attachment #528621 - Flags: review?(robert.bugzilla) → review+
Comment on attachment 528620 [details] [diff] [review]
move toolkit/mozapps/xpinstall

Would be nice to get the other places in the repos that reference xpinstallConfirm.xul updated as well.
http://mxr.mozilla.org/mozilla-central/source/xulrunner/app/xulrunner.js#43

http://mxr.mozilla.org/comm-central/source/calendar/sunbird/app/profile/sunbird.js#101
Attachment #528620 - Flags: review?(robert.bugzilla) → review+
Whiteboard: [has patch][needs review rs][needs review dveditz][needs review khuey] → [has patch][needs review dveditz][needs review khuey]
Attachment #528621 - Flags: review?(khuey) → review+
Whiteboard: [has patch][needs review dveditz][needs review khuey] → [has patch][needs review dveditz]
Blocks: 665023
(Assignee)

Comment 9

6 years ago
Dan, any chance of getting the final sign off to remove all this code?

Comment 10

6 years ago
Brian and I think this does not block "switch to pkix by default", but it should be fixed soon; moving it to a tracker bug for major PKIX related issues.
Blocks: 686933
No longer blocks: 651246

Updated

6 years ago
Blocks: 113234
(Assignee)

Comment 11

5 years ago
Jorge, I was going to land the reviewed pieces of this soon but they have some extension impact. They will move a bunch of UI and locale files from chrome://mozapps/xxx/xpinstall/ to chrome://mozapps/xxx/extensions/. I wanted to hear if you thought that would be a particular issue for extension compatibility since it is also possible to just leave them in the same chrome locations (though it would certainly be cleaner and more logical to move them since we're moving the files)
The impact is significant, affecting roughly 50 add-ons on AMO: https://mxr.mozilla.org/addons/search?string=%2Fxpinstall%2F&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=addons

I see some of them point to DTD files, which could break the add-on or Firefox badly. I'd recommend to keep the chrome paths intact, or at least have a deprecation period where both paths work and an error is shown in the Error Console for using the old ones.
(Assignee)

Comment 13

5 years ago
Created attachment 576633 [details] [diff] [review]
move toolkit/mozapps/xpinstall

This is an updated patch that does the file moves but leaves the chrome locations for all the files the same so it shouldn't break extensions
Attachment #528620 - Attachment is obsolete: true
Attachment #576633 - Flags: review?(robert.bugzilla)
Comment on attachment 576633 [details] [diff] [review]
move toolkit/mozapps/xpinstall

All of the changes look sane though I didn't look very hard.
Attachment #576633 - Flags: review?(robert.bugzilla) → review+
Comment on attachment 576633 [details] [diff] [review]
move toolkit/mozapps/xpinstall

also need to update toolkit-makefiles.sh
bah, please fix this too
+  
\ No newline at end of file
(Assignee)

Comment 17

5 years ago
Landed the reviewed patches on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/c7e620a0c5b5
https://hg.mozilla.org/integration/mozilla-inbound/rev/79b80511d577
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5229443d6a2
(Assignee)

Comment 18

5 years ago
Bleh and https://hg.mozilla.org/integration/mozilla-inbound/rev/5e2bfc3905cb
https://hg.mozilla.org/mozilla-central/rev/c7e620a0c5b5
https://hg.mozilla.org/mozilla-central/rev/79b80511d577
https://hg.mozilla.org/mozilla-central/rev/e5229443d6a2
https://hg.mozilla.org/mozilla-central/rev/5e2bfc3905cb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
attachment 528622 [details] [diff] [review] doesn't seem to have landed yet.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 528622 [details] [diff] [review]
remove xpinstall

Review of attachment 528622 [details] [diff] [review]:
-----------------------------------------------------------------

r=dveditz
Attachment #528622 - Flags: review?(dveditz) → review+
(Assignee)

Comment 22

5 years ago
Final patch is on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/8d5aa2c53f04
https://hg.mozilla.org/mozilla-central/rev/8d5aa2c53f04
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.