665267 - Contacts Sidebar: Please add a "confirm on delete" option for address book entries

Status: RESOLVED WORKSFORME

(Thunderbird :: Message Compose Window, defect)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #526541 +++

After 10 years of user requests (Bug 94407), Bug 526541 has finally addressed a longstanding address book dataloss problem by adding "confirm on delete" option for the main address book. The warning pops up regardless of the method used for deletion (DEL, context menu, or toolbar button), and rightly so.

We need the same warning for deletion of address book entries from the *contacts sidebar* during composition, regardless of the method used for deletion (In the sidebar, currently we only allow deletion via context menu, but after adding the confirmation - this bug -, we'll be able to have DEL key as well - bug 343973).

Blake mentions the main reason why this is needed, bug 526541, comment 23:
> we can't undo that deletion [i.e., if triggered accidentally for whatever reason, the data vanishes silently without any indication or any way of recovery].
But even after implementing undo, we still need the confirmation, as laid out in bug 526541, comment 15.

STR

1 Select one or multiple contacts from contacts sidebar
2 right-click, select "Delete" from context menu accidentally (e.g. you just missed "Properties" with your mouse)

Actual result
- valuable address book data vanishes silently without any indication (this bug), and without any way of recovery (bug 94407)

Expected result
- protect valuable address book data against accidental deletion by adding a warning confirmation
- I suppose we can use the same strings as in bug 526541:
> +confirmDeleteContact=Are you sure you want to delete the selected contact?
> +confirmDeleteContacts=Are you sure you want to delete the selected contacts?

Mike Conley (the hero who fixed bug 526541), do you think you could take this to complement bug 526541?

Comment 1

[Thomas Kregelin]

I just tried to delete some contacts from the sidebar as explained in the Description. 

Upon deleting a contact with the right-click option I get a popup windows asking me whether I really wanted to delete the selected contacts (one or more selected).

However, I can not use the DEL key to delete contacts in the sidebar view.

I am running TB 9.01 in German on Win 7.

Is this issue fixed then?

Comment 2

[Thomas D. (:thomas8)]

Jim, or Ludo, do you know what fixed this? I'd prefer marking this fixed instead of wfm.

(In reply to Thomas Kregelin from comment #1)
> I am running TB 9.01 in German on Win 7.
> I just tried to delete some contacts from the sidebar as explained in the
> Description. 
> Upon deleting a contact with the right-click option I get a popup windows
> asking me whether I really wanted to delete the selected contacts (one or
> more selected).
> Is this issue fixed then?

Yes! Thanks Thomas K. for tracking this.

> However, I can not use the DEL key to delete contacts in the sidebar view.

That's Bug 343973. Pls encourage people to vote for it.