Closed
Bug 665373
Opened 13 years ago
Closed 12 years ago
Switch to BrowserID based login
Categories
(Participation Infrastructure :: Phonebook, defect)
Participation Infrastructure
Phonebook
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: ozten, Assigned: ozten)
References
Details
(Whiteboard: [l10n impact])
Attachments
(1 file)
15.48 KB,
patch
|
Milos
:
review-
|
Details | Diff | Splinter Review |
Once https://browserid.org/ has reached Milestone 3, we should implement a staging site or prototype that lets you log in via your ... wait for it... browser and verified email. Milestone 3 tracker - https://github.com/mozilla/browserid/issues/milestones?direction=asc&sort=due_date
Assignee | ||
Updated•13 years ago
|
Target Milestone: --- → 1.2
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → ozten.bugs
Assignee | ||
Comment 2•13 years ago
|
||
I've looked into various ways of doing this. The most promising (and most painful :) is to write a C plugin for CMU SASL. This is already integrated into OpenLDAP. I've prototyped a solution and almost have it working for the happy case. I'll hopefully put up a github repo soon to get feedback and help.
Comment 3•13 years ago
|
||
when is browserid.org supposed to reach milestone 3? Is there a wiki page assocaited to it?
Priority: -- → P1
Updated•13 years ago
|
Priority: P1 → --
Target Milestone: 1.2 → ---
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to Aakash Desai [:aakashd] from comment #3) You can dis-regard Milestone 3. Looks like my comment was mid-aired and I closed the tab last week :( I've started working on a SASL C plugin [1]. I'm working with other teams to make sure this is a good idea (Andrew Findlay, Security, Ops, and Labs). Being C, I will be much slower at writing this code. Next Steps: * Research a non-plugin strategy (to avoid writing/maintaining this C code) * Reach out to the CMU SASL mailing list * Writing the SASL plugin [1] https://github.com/ozten/sasl-browserid
Comment 5•13 years ago
|
||
omg hawt. ok.
Updated•13 years ago
|
Target Milestone: --- → 1.3
Assignee | ||
Comment 6•13 years ago
|
||
This is working enough to demonstrate a solution, but doesn't have all the UX for how BrowserID and registration should work, etc. Code: https://github.com/ozten/mozillians/tree/browserid https://github.com/ozten/sasl-browserid Filed Bug#684085 for security review of proposed solution.
Assignee | ||
Comment 7•13 years ago
|
||
Notifying teams to get sasl-browserid reviewed, tested, etc. Filed Bug#687094 to work out UX.
Depends on: 687094
Assignee | ||
Comment 9•13 years ago
|
||
Changing the title as we head into Security Review.
Summary: Prototype BrowserID based login → Switch to BrowserID based login
Assignee | ||
Comment 10•13 years ago
|
||
This bug depends on sasl-browserid. Investigating https://github.com/ozten/sasl-browserid/issues/4
Assignee | ||
Comment 11•13 years ago
|
||
(In reply to Austin King [:ozten] from comment #10) Fixed issue 4. I'm unblocked.
Assignee | ||
Comment 12•13 years ago
|
||
I've got the unit tests passing and things working with the 1.1 release. Ready for code review at https://github.com/mozilla/mozillians/pull/59 Thanks!
Assignee | ||
Comment 13•13 years ago
|
||
I've run extract in the browserid-1_1 branch, then svn diff in the locale directory. Output is attached for review and string freeze today. Note: Code is still under code review, I'll ping if anything changes.
Attachment #577647 -
Flags: review?(milos)
Comment 14•13 years ago
|
||
Comment on attachment 577647 [details] [diff] [review] svn diff locale directory Review of attachment 577647 [details] [diff] [review]: ----------------------------------------------------------------- And an overall comment: I can see that you have extracted much more than BrowserId, if I'm not mistaken. Please extract only browserid strings and ask me for a review again. ::: templates/LC_MESSAGES/messages.pot @@ +301,4 @@ > msgstr "" > > #: apps/phonebook/templates/phonebook/home.html:7 > +msgid "This website requires JavaScript to be turned on." We should be using "This website requires JavaScript enabled in your browser", or something along that line. So "turned on" vs "enabled".
Attachment #577647 -
Flags: review?(milos) → review-
Assignee | ||
Comment 15•13 years ago
|
||
(In reply to Milos Dinic [:Milos] from comment #14) Thanks for your help. Updated https://github.com/mozilla/mozillians/commit/efd29789d3476a287e2f8194a89e9850fc32ff80 Updated Affiliates noscript copy also (not pushed to master yet).
Assignee | ||
Updated•13 years ago
|
Whiteboard: [l10n impact]
Assignee | ||
Comment 16•13 years ago
|
||
Thanks to davedash and tofumatt, code is on master so it shoudl be on https://mozillians-dev.allizom.org/en-US/ in 10-15 minutes. I'll test once it shows up, to make sure -dev is in a good state for QA.
Assignee | ||
Comment 17•13 years ago
|
||
Looks like our -dev environment doesn't like browserid.org's SSL cert. http://jason.pastebin.mozilla.org/1397335
Assignee | ||
Comment 18•13 years ago
|
||
Jason and Pete have fixed the SSL cert issue. We're running YAJL 2.0.2, but we need 2.0.3. Filed Bug#709886 to track this update.
Depends on: 709886
Twice Done.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Component: mozillians.org → Phonebook
Product: Websites → Community Tools
QA Contact: mozillians-org → phonebook
Target Milestone: 1.3 → ---
Version: unspecified → other
You need to log in
before you can comment on or make changes to this bug.
Description
•