665502 - tabItems are resized when closing the active tab in a group

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect)

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Regressed since bug 642793.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 540434 [details] [diff] [review]
patch v1

>+      win.gBrowser.loadOneTab("about:blank", {inBackground: true});

Why isn't this just win.gBrowser.addTab();?

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

(In reply to comment #3)
> >+      win.gBrowser.loadOneTab("about:blank", {inBackground: true});
> 
> Why isn't this just win.gBrowser.addTab();?

Because that would add a new tab and make it the selectedTab, right? I wanted the first tab to stay selected.

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #4)
> (In reply to comment #3)
> > >+      win.gBrowser.loadOneTab("about:blank", {inBackground: true});
> > 
> > Why isn't this just win.gBrowser.addTab();?
> 
> Because that would add a new tab and make it the selectedTab, right?

Nope, addTab never does that.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v2

Replaced gBrowser.loadOneTab() with gBrowser.addTab()

Comment 7

[Raymond Lee [:raymondlee]]

Comment on attachment 540438 [details] [diff] [review]
patch v2

Looks good!

Comment 8

[Dietrich Ayala (:dietrich)]

Comment on attachment 540438 [details] [diff] [review]
patch v2

Review of attachment 540438 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f7a2b52a76fd

Comment 10

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/f7a2b52a76fd

Comment 11

[George Carstoiu]

Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110626 Firefox/7.0a1

Verified on Ubuntu 11.04 x86, Mac OS X 10.6, Win 7 x86, Win XP using the following steps:
1. Open several tabs
2. Enter Panorama
3. Close the focused tab and observe the other tabs.

Issue is no longer reproducible. Setting status to Verified Fixed.