tabItems are resized when closing the active tab in a group

VERIFIED FIXED in Firefox 7

Status

Firefox Graveyard
Panorama
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

({regression})

Trunk
Firefox 7
regression
Dependency tree / graph
Bug Flags:
in-testsuite +

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Regressed since bug 642793.
Depends on: 642793
(Assignee)

Comment 2

6 years ago
Created attachment 540434 [details] [diff] [review]
patch v1
Attachment #540434 - Flags: feedback?(raymond)
Comment on attachment 540434 [details] [diff] [review]
patch v1

>+      win.gBrowser.loadOneTab("about:blank", {inBackground: true});

Why isn't this just win.gBrowser.addTab();?
(Assignee)

Comment 4

6 years ago
(In reply to comment #3)
> >+      win.gBrowser.loadOneTab("about:blank", {inBackground: true});
> 
> Why isn't this just win.gBrowser.addTab();?

Because that would add a new tab and make it the selectedTab, right? I wanted the first tab to stay selected.
(In reply to comment #4)
> (In reply to comment #3)
> > >+      win.gBrowser.loadOneTab("about:blank", {inBackground: true});
> > 
> > Why isn't this just win.gBrowser.addTab();?
> 
> Because that would add a new tab and make it the selectedTab, right?

Nope, addTab never does that.
(Assignee)

Comment 6

6 years ago
Created attachment 540438 [details] [diff] [review]
patch v2

Replaced gBrowser.loadOneTab() with gBrowser.addTab()
Attachment #540434 - Attachment is obsolete: true
Attachment #540434 - Flags: feedback?(raymond)
Attachment #540438 - Flags: feedback?(raymond)
Comment on attachment 540438 [details] [diff] [review]
patch v2

Looks good!
Attachment #540438 - Flags: feedback?(raymond) → feedback+
(Assignee)

Updated

6 years ago
Attachment #540438 - Flags: review?(dietrich)
Comment on attachment 540438 [details] [diff] [review]
patch v2

Review of attachment 540438 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #540438 - Flags: review?(dietrich) → review+
(Assignee)

Comment 9

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/f7a2b52a76fd
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/f7a2b52a76fd
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 7

Comment 11

6 years ago
Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110626 Firefox/7.0a1

Verified on Ubuntu 11.04 x86, Mac OS X 10.6, Win 7 x86, Win XP using the following steps:
1. Open several tabs
2. Enter Panorama
3. Close the focused tab and observe the other tabs.

Issue is no longer reproducible. Setting status to Verified Fixed.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.