Unsupported types of inline settings show as an empty row

VERIFIED FIXED in mozilla7

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Unfocused, Assigned: darktrojan)

Tracking

Trunk
mozilla7
Points:
---
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

When an extension uses an inline setting that isn't supported by the addons manager (such as one that was added in a later version), it shows as an empty row - which makes it look broken.
(Assignee)

Comment 1

6 years ago
Created attachment 540623 [details] [diff] [review]
patch
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #540623 - Flags: review?(bmcbride)
Comment on attachment 540623 [details] [diff] [review]
patch

Looks good. Would like a test for the first-row attribute though.
Attachment #540623 - Flags: review?(bmcbride) → review-
(Assignee)

Comment 3

6 years ago
Created attachment 541347 [details] [diff] [review]
patch
Attachment #540623 - Attachment is obsolete: true
Attachment #541347 - Flags: review?(bmcbride)
Attachment #541347 - Flags: review?(bmcbride) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 542652 [details] [diff] [review]
patch minus bitrot
Attachment #541347 - Attachment is obsolete: true
(Assignee)

Comment 5

6 years ago
This needs to be checked in after bug 665378.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/dad2f5b0bc1f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0a1) Gecko/20110703 Firefox/7.0a1
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.