665569 - Add GetFileFromString helper for getting File from native path or Url

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Ian Neal]

At the moment downloadmanager.js has a helper for converting a string that could be either a native path or Url to a File.
This patch:
* Moves the helper into utilityOverlay.js so that it can be used elsewhere and renames it.
* Makes use of commandline resolveURI to simplify the helper.
* Switches some suite code to use the new helper.

Comment 1

[Ian Neal]

Attachment: GetFileFromString helper [Checked in: Comment 5]

Comment 2

[[e-mail]]

(From update of attachment 540487 [details] [diff] [review])
>       var size = null;
>       if (isExternalAttachment)
>       {
>-        var fileHandler = Services.io.getProtocolHandler("file")
>-                                     .QueryInterface(Components.interfaces.nsIFileProtocolHandler);
>-        try
>-        {
>-          size = fileHandler.getFileFromURLSpec(url).fileSize;
bienvenu, are we guaranteed that the url of an external attachment is a file URL, and therefore the only reason to swallow the exception is in case the file (size) doesn't exist?

Comment 3

[David :Bienvenu]

(In reply to comment #2)

> bienvenu, are we guaranteed that the url of an external attachment is a file
> URL, and therefore the only reason to swallow the exception is in case the
> file (size) doesn't exist?

Yes, it has to be a file url, because the external attachment header is generated by detaching an attachment. I suppose someone could fake that header and use a different kind of url, and perhaps we shouldn't swallow *that* exception.

Comment 4

[[e-mail]]

Comment on attachment 540487 [details] [diff] [review]
GetFileFromString helper [Checked in: Comment 5]

>+  let commandLine = Components.classes["@mozilla.org/toolkit/command-line;1"]
>+                              .createInstance();
Nit: I'd prefer you to mention nsICommandLine as it's not obvious enough.

Comment 5

[Ian Neal]

Comment on attachment 540487 [details] [diff] [review]
GetFileFromString helper [Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/bc728348268b