665603 - Centralise sound preferences

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Ian Neal]

Attachment: centralise sound preferences [Checked in: Comment 3]

At the moment there is very similar code in pref-download.js, pref-popup.js and pref-notifications.js which could all be centralised into preferences.js and then called from the respective xul files.
This patch:
* Creates WriteSoundField, SelectSound and PlaySound functions in preferences.js
* Updates the relevant xul files to call these new functions instead.
* Removes unneeded code from the relevant js files, tweaking code where needed.
* Removes unneeded entities from pref-popups.dtd

This code depends on GetFileFromString helper which is part of bug 665569.

Comment 1

[Philip Chee]

> +  var filterExts = "*.wav; *.wave";
> +  // On Mac, allow AIFF files too.
> +  if (/Mac/.test(navigator.platform))
> +    filterExts += "; *.aif; *.aiff";
Ah good show! I was going to mention Thunderbird Bug 491359.

Comment 2

[Karsten Düsterloh]

Comment on attachment 540520 [details] [diff] [review]
centralise sound preferences [Checked in: Comment 3]

Review of attachment 540520 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/common/pref/preferences.js
@@ +71,5 @@
> +  var fp = Components.classes["@mozilla.org/filepicker;1"]
> +                     .createInstance(nsIFilePicker);
> +  var prefutilitiesBundle = document.getElementById("bundle_prefutilities");
> +  fp.init(window, prefutilitiesBundle.getString("choosesound"),
> +          nsIFilePicker.modeOpen);

No need to wrap here, imo.

Comment 3

[Ian Neal]

Comment on attachment 540520 [details] [diff] [review]
centralise sound preferences [Checked in: Comment 3]

http://hg.mozilla.org/comm-central/rev/ae84f8b74c90

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 540520 [details] [diff] [review]
centralise sound preferences [Checked in: Comment 3]

Review of attachment 540520 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/common/pref/pref-popups.js
@@ -40,4 @@
>  var gSoundUrlPref;
> -var gSelectSound;
> -
> -var gIOService;

http://mxr.mozilla.org/comm-central/source/suite/common/pref/pref-popups.js#60

Grr. :-(