665716 - build breaks when building SUTAgent with sdk level 11

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

if your mozconfig specifies:
ac_add_options --with-android-sdk="<path to your sdk>/platforms/android-11"

the build will break when building the SUTAgent with:
symbol  : method setForeground(boolean)
location: class com.mozilla.SUTAgentAndroid.service.ASMozStub
        setForeground(true);
        ^
/home/vmuser/Android/MC-18-06-2011/build/mobile/sutagent/android/ASMozStub.java:213: cannot find symbol
symbol  : method setForeground(boolean)
location: class com.mozilla.SUTAgentAndroid.service.ASMozStub
        setForeground(false);
        ^
2 errors
make[6]: *** [classes.dex] Error 1

Comment 1

[Bob Moss :bmoss]

Attachment: Patch to fix calls to setForeground in android

This should resolve the undefined symbol issue.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 540621 [details] [diff] [review]
Patch to fix calls to setForeground in android

We use Log.e() to log errors in regular fennec code. Does Exception.printStackTrace() go the the android log? Or does it just get lost in stderr?

Comment 3

[Bob Moss :bmoss]

Yes, I believe that it does go to the android log.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a0f38e290e33

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/a0f38e290e33

Comment 6

[Bob Moss :bmoss]

Attachment: Patch to fix calls to setForeground in android in the watcher service code

This patch will take care of the setForeground api call in the watcher module for SUTAgent.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

follow up patch on inbound
http://hg.mozilla.org/integration/mozilla-inbound/rev/d618c3a26cd4

Comment 8

[Mounir Lamouri (:mounir)]

(In reply to Brad Lassey [:blassey][[e-mail]] from comment #7)
> follow up patch on inbound
> http://hg.mozilla.org/integration/mozilla-inbound/rev/d618c3a26cd4

and merged:
http://hg.mozilla.org/mozilla-central/rev/d618c3a26cd4