Closed
Bug 665986
Opened 13 years ago
Closed 13 years ago
rewrite codebases.php to be less verbose (fix vcsMappings)
Categories
(Socorro :: General, task, P1)
Socorro
General
Tracking
(Not tracked)
RESOLVED
FIXED
2.1
People
(Reporter: rhelmer, Assigned: rhelmer)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 2 obsolete files)
4.08 KB,
patch
|
brandon
:
review+
|
Details | Diff | Splinter Review |
codebases.php defined a vcsMappins array which looks like this: 'hg' => array( 'hg.mozilla.org/camino' => 'http://hg.mozilla.org/camino/annotate/%(revision)s/%(file)s#l%(line)s', 'hg.mozilla.org/mozilla-central' => 'http://hg.mozilla.org/mozilla-central/annotate/%(revision)s/%(file)s#l%(line)s', 'hg.mozilla.org/releases/mozilla-1.9.1' => 'http://hg.mozilla.org/releases/mozilla-1.9.1/annotate/%(revision)s/%(file)s#l%(line)s', ... It is occasionally updated manually such as bug 649418. Since these all follow the same pattern, we should have that as a hardcoded default and allow overriding instead.
Comment 1•13 years ago
|
||
I actually think we should just make it smarter. Maybe just drop CVS support, and add built-in support for hgweb, so that we take: hg:<repo>:<path>:<changeset> -> http://<repo>/<annotate/<changeset>/<path> (and tack on the #l<line> at some point). It'd probably be trivial to add equivalent built-in support for gitweb too, if someone wanted it.
Assignee | ||
Comment 2•13 years ago
|
||
Ted I think we are pretty much in agreement, but I decided to respond with a patch instead :) I think we can get to the goal of not having to touch codebases.php anymore with a very small change. This simply splits out the repo from the server, so we can build all the links from one pattern. Leaves CVS support etc. in place, at least for now. codebases.php should not need any updates for new repos if we do something along these lines.
Assignee | ||
Updated•13 years ago
|
Attachment #541086 -
Flags: review?(bsavage)
Comment 3•13 years ago
|
||
This sounds reasonable, just one possible bug I see in your patch. You probably need to pass a limit of 2 to explode, so that this doesn't break repos like /releases/foo.
Assignee: nobody → rhelmer
Assignee | ||
Comment 4•13 years ago
|
||
Oops use the correct/tested patch
Attachment #541086 -
Attachment is obsolete: true
Attachment #541092 -
Flags: review?(bsavage)
Attachment #541086 -
Flags: review?(bsavage)
Assignee | ||
Comment 5•13 years ago
|
||
Thanks Ted, right you are. Tested this with repos of the form: hg.mozilla.org/blah hg.mozilla.org/projects/blah
Attachment #541092 -
Attachment is obsolete: true
Attachment #541094 -
Flags: review?(bsavage)
Attachment #541092 -
Flags: review?(bsavage)
![]() |
||
Comment 7•13 years ago
|
||
Fixing this is necessary to get linking working for builds from mozilla-releases. Any chance you can look at this patch soon bsavage? It looks good to me.
Assignee | ||
Updated•13 years ago
|
Target Milestone: --- → 2.1
Assignee | ||
Updated•13 years ago
|
Priority: -- → P1
Comment 9•13 years ago
|
||
Can we get a review on this or bounce this to someone else? The broken stacks are a serious productivity loss for people who have to look at them.
Updated•13 years ago
|
Summary: rewrite codebases.php to be less verbose → rewrite codebases.php to be less verbose (fix vcsMappings)
Comment 11•13 years ago
|
||
Comment on attachment 541094 [details] [diff] [review] address ted's concern in comment 3 A stroke of genius. r+ from me.
Attachment #541094 -
Flags: review?(bsavage) → review+
Assignee | ||
Comment 12•13 years ago
|
||
(In reply to comment #11) > Comment on attachment 541094 [details] [diff] [review] [review] > address ted's concern in comment 3 > > A stroke of genius. r+ from me. Let's not get carried away :P Thanks for the review. Landed on trunk: Committed revision 3268. I've added this bug to today's status meeting discussion, so we can figure out how soon this will get deployed https://wiki.mozilla.org/Breakpad/Status_Meetings/2011-July-06
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [qa-]
Updated•13 years ago
|
Component: Socorro → General
Product: Webtools → Socorro
You need to log in
before you can comment on or make changes to this bug.
Description
•