Last Comment Bug 666135 - Disable -Wcast-align when building with clang
: Disable -Wcast-align when building with clang
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
-- normal (vote)
: ---
Assigned To: Craig Topper
: Gregory Szorc [:gps] (away until 2017-03-20)
Depends on:
Blocks: clang
  Show dependency treegraph
Reported: 2011-06-21 23:53 PDT by Craig Topper
Modified: 2011-06-28 09:17 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Disable -Wcast-align when building with clang (5.53 KB, patch)
2011-06-22 00:16 PDT, Craig Topper
ted: review+
Details | Diff | Splinter Review

Description User image Craig Topper 2011-06-21 23:53:00 PDT
The -Wcast-align flag causes clang to print a lot of warnings. Bug 662971, bug 662969, bug 662964, bug 662962, and bug 662961 have been filed to fix some of these. A better solution is to just disable the flag when building with clang.

It is already disabled on other platforms and compilers due to the amount of warnings it causes in those cases. See bugs 411292, bug 436133, and bug 557758.
Comment 1 User image Craig Topper 2011-06-22 00:16:19 PDT
Created attachment 540979 [details] [diff] [review]
Disable -Wcast-align when building with clang
Comment 2 User image Ted Mielczarek [:ted.mielczarek] 2011-06-27 08:00:19 PDT
Comment on attachment 540979 [details] [diff] [review]
Disable -Wcast-align when building with clang

Review of attachment 540979 [details] [diff] [review]:

@@ +1581,1 @@
>         # Don't use -Wcast-align with ICC

Can you fix the comment here to mention clang too?

@@ +1631,1 @@
>         # Don't use -Wcast-align with ICC

Here as well.
Comment 3 User image Craig Topper 2011-06-27 21:42:47 PDT
Pushed to inbound with the comment fixed in both files
Comment 4 User image Joe Drew (not getting mail) 2011-06-28 09:17:04 PDT

Note You need to log in before you can comment on or make changes to this bug.