Disable -Wcast-align when building with clang

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Craig Topper, Assigned: Craig Topper)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The -Wcast-align flag causes clang to print a lot of warnings. Bug 662971, bug 662969, bug 662964, bug 662962, and bug 662961 have been filed to fix some of these. A better solution is to just disable the flag when building with clang.

It is already disabled on other platforms and compilers due to the amount of warnings it causes in those cases. See bugs 411292, bug 436133, and bug 557758.
(Assignee)

Updated

6 years ago
Blocks: 574346
(Assignee)

Comment 1

6 years ago
Created attachment 540979 [details] [diff] [review]
Disable -Wcast-align when building with clang
(Assignee)

Updated

6 years ago
Attachment #540979 - Flags: review?(ted.mielczarek)
Assignee: nobody → craig.topper
Comment on attachment 540979 [details] [diff] [review]
Disable -Wcast-align when building with clang

Review of attachment 540979 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +1581,1 @@
>         # Don't use -Wcast-align with ICC

Can you fix the comment here to mention clang too?

@@ +1631,1 @@
>         # Don't use -Wcast-align with ICC

Here as well.
Attachment #540979 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

6 years ago
Pushed to inbound with the comment fixed in both configure.in files
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/0c259dad48ac
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.