The default bug view has changed. See this FAQ.

Progress bars on Windows Classic need a padding

RESOLVED FIXED in mozilla7

Status

()

Core
Widget: Win32
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

6 years ago
It looks like GetWidgetPadding doesn't work for Windows Classic. We should probably write a ClassicGetWidgetPadding.
(Assignee)

Comment 1

6 years ago
Created attachment 540998 [details]
Firefox progress bar
(Assignee)

Comment 2

6 years ago
Created attachment 540999 [details]
Progress bar in Security Essentials
(Assignee)

Comment 3

6 years ago
Created attachment 541000 [details]
Progress bar during security update
(Assignee)

Updated

6 years ago
Attachment #540999 - Attachment description: Progress bar in the Security Update program → Progress bar in Security Essentials

Comment 4

6 years ago
Bug 661846 (currently awaiting checkin) will add a ClassicGetWidgetPadding function when it lands.
(Assignee)

Updated

6 years ago
Depends on: 661846
(Assignee)

Comment 5

6 years ago
(In reply to comment #4)
> Bug 661846 (currently awaiting checkin) will add a ClassicGetWidgetPadding
> function when it lands.

Awesome! I just pushed it to mozilla-inbound. That should make this bug a 3 line-patch ;)
(Assignee)

Comment 6

6 years ago
Created attachment 541019 [details] [diff] [review]
Add 1px padding for progress with the Classic theme
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #541019 - Flags: review?(jmathies)

Updated

6 years ago
Attachment #541019 - Flags: review?(jmathies) → review+
(Assignee)

Updated

6 years ago
Attachment #541019 - Flags: checkin+
(Assignee)

Updated

6 years ago
Whiteboard: [inbound]
(Assignee)

Comment 7

6 years ago
Pushed:
http://hg.mozilla.org/mozilla-central/rev/311835bfec30
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7

Comment 8

6 years ago
Mounir, can you take a look at Bug 661375? I think it requires a similar patch

Comment 9

6 years ago
Hi guys.
Can you attach a testcase in order to verify this. 
Thanks.
You need to log in before you can comment on or make changes to this bug.