If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

simple, glyphs for the message header buttons

RESOLVED FIXED in Thunderbird 10.0

Status

Thunderbird
Theme
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: andreasn, Assigned: andreasn)

Tracking

Trunk
Thunderbird 10.0
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 541024 [details]
mockup

Simpler icons looks really nice, similar to bug 665871 it would look nice to do this for the message header graphics as well.
(Assignee)

Updated

6 years ago
Blocks: 665873
(Assignee)

Comment 1

6 years ago
Created attachment 547053 [details] [diff] [review]
monochrome message header icons

This implements the single colored icons for the message header using the text color.
(Assignee)

Comment 2

6 years ago
One thing I removed, that I'm uncertain about what it did there to begin with was the two different sizes for the icons, as there is no way to change the size of these icons in the ui (that I know of).
It might have been:
1. Code that was left around that we forgot to remove earlier
2. Code for the Compact Header addon, (but I think that css should live in the compact header addon in that case, as it's useless to TB Core)
I think it is 1. Compact Header has removed the size chooser before it was in TB core removed.
(Assignee)

Comment 4

6 years ago
Oh, in that case it's probably safe to remove then.
No review requests?
(Assignee)

Updated

6 years ago
Attachment #547053 - Flags: ui-review?(bwinton)
(Assignee)

Updated

6 years ago
Attachment #547053 - Flags: review?(squibblyflabbetydoo)

Comment 6

6 years ago
Comment on attachment 547053 [details] [diff] [review]
monochrome message header icons

Review of attachment 547053 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, though we'll also need to remove the styles for .hdrArchiveButton > .button-box > .button-icon and .hdrTrashButton > .button-box > .button-icon from messageHeader.css. However, I'll handle that in bug 673322, since I already have a WIP patch for that.

::: mail/themes/gnomestripe/mail/messageHeader.css
@@ +301,5 @@
>  }
>  
>  .hdrReplyToSenderButton {
> +  list-style-image: url("chrome://messenger/skin/icons/button-reply.svg");
> +/*  -moz-image-region: rect(0px 96px 24px 72px); */

We should remove this commented-out line.

@@ +306,5 @@
>  }
>  
>  .hdrReplyButton {
> +  list-style-image: url("chrome://messenger/skin/icons/button-reply.svg");
> +/*  -moz-image-region: rect(0px 96px 24px 72px); */

Here too.
Attachment #547053 - Flags: review?(squibblyflabbetydoo) → review+
(Assignee)

Comment 7

6 years ago
Created attachment 548586 [details] [diff] [review]
updated patch

with commented out parts removed. Carrying over r+
Attachment #547053 - Attachment is obsolete: true
Attachment #548586 - Flags: ui-review?(bwinton)
Attachment #548586 - Flags: review+
Attachment #547053 - Flags: ui-review?(bwinton)
(Assignee)

Updated

6 years ago
Assignee: nobody → nisses.mail
Comment on attachment 548586 [details] [diff] [review]
updated patch

First off, the patch has been bit-rotted by Jim, so we'll need a new one.  Given that, I mostly like it, but…

In High/Inverse Contrast the icons should change to white, because they're really hard to see: http://dl.dropbox.com/u/2301433/Screenshots/HighContrast.png

So, I think I'm going to say ui-r- but you're very close.

Thanks,
Blake.
Attachment #548586 - Flags: ui-review?(bwinton) → ui-review-
(Assignee)

Comment 9

6 years ago
Created attachment 561742 [details] [diff] [review]
fixes bitrot

This patch fixes the bitrot. I was able to reproduce the High/Inverse issues and it goes away on a restart of Thunderbird. Is it safe to assume that someone will run Normal, HC or HC/Inverse but not really switch between them on a regular basis while running Thunderbird?
(Assignee)

Comment 10

6 years ago
Comment on attachment 561742 [details] [diff] [review]
fixes bitrot

Forgot to add the ui-review flag to this.
Attachment #561742 - Flags: ui-review?(bwinton)
Comment on attachment 561742 [details] [diff] [review]
fixes bitrot

Review of attachment 561742 [details] [diff] [review]:
-----------------------------------------------------------------

> I was able to reproduce the High/Inverse issues and it goes away on a restart of Thunderbird.
> Is it safe to assume that someone will run Normal, HC or HC/Inverse but not really switch
> between them on a regular basis while running Thunderbird?

Yeah, that's probably a safe assumption.  Can you write email to Ludo and tell him about this for when he tests the contrast-switching stuff?
(Also, why is there a "Low Contrast" mode?!?)

Anyways, ui-r=me!

Thanks,
Blake.
Attachment #561742 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 12

6 years ago
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #11)

> Yeah, that's probably a safe assumption.  Can you write email to Ludo and
> tell him about this for when he tests the contrast-switching stuff?
Done.
Attachment #548586 - Attachment is obsolete: true
Checked in as http://hg.mozilla.org/comm-central/rev/7acf46d99cea
Target Milestone: --- → Thunderbird 10.0
Keywords: checkin-needed
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 14

6 years ago
This bug report states "This implements the single colored icons for the message header using the text color." However, it always uses black, even when the text colors are changed using tools -> options -> display -> formatting and Thunderbird restarted. I tested this with both Thunderbird 10.0 and 20120131 Thunderbird/12.0a1 in safe mode under Vista.
The color is used from the system text color and not from TB's text color.
You need to log in before you can comment on or make changes to this bug.