Last Comment Bug 666574 - Advanced pref pane shouldn't use setBoolPref
: Advanced pref pane shouldn't use setBoolPref
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Preferences (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 7
Assigned To: Steffen Wilberg
:
Mentors:
Depends on: 594173
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-23 06:53 PDT by Steffen Wilberg
Modified: 2011-06-27 02:09 PDT (History)
4 users (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (3.26 KB, patch)
2011-06-23 06:56 PDT, Steffen Wilberg
asaf: review+
Details | Diff | Review

Description Steffen Wilberg 2011-06-23 06:53:32 PDT
The prefwindow doesn't need to hack around with setBoolPref.
setBoolPref applies instantly, which is wrong on Windows.
Use <preference>.value instead.
Comment 1 Steffen Wilberg 2011-06-23 06:56:13 PDT
Created attachment 541363 [details] [diff] [review]
patch

The invertion of !pref.value is now done by the preference element's inverted="true".
Comment 2 Mano (::mano, needinfo? for any questions; not reading general bugmail) 2011-06-23 23:10:15 PDT
Comment on attachment 541363 [details] [diff] [review]
patch

r=mano
Comment 4 Mounir Lamouri (:mounir) 2011-06-27 02:09:44 PDT
Merged:
http://hg.mozilla.org/mozilla-central/rev/28e4374838c4

Note You need to log in before you can comment on or make changes to this bug.