Closed Bug 666574 Opened 12 years ago Closed 12 years ago

Advanced pref pane shouldn't use setBoolPref

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 7

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

Details

Attachments

(1 file)

patch
3.26 KB, patch
asaf
: review+
Details | Diff | Splinter Review 
The prefwindow doesn't need to hack around with setBoolPref.
setBoolPref applies instantly, which is wrong on Windows.
Use <preference>.value instead.
Attached patch patch — — Splinter Review 
The invertion of !pref.value is now done by the preference element's inverted="true".
Attachment #541363 - Flags: review?(mano)
Comment on attachment 541363 [details] [diff] [review]
patch

r=mano
Attachment #541363 - Flags: review?(mano) → review+
Merged:
http://hg.mozilla.org/mozilla-central/rev/28e4374838c4
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 7
You need to log in before you can comment on or make changes to this bug.