Advanced pref pane shouldn't use setBoolPref

RESOLVED FIXED in Firefox 7

Status

()

Product:
Firefox
Component:
Preferences
RESOLVED FIXED
Reported:
6 years ago
Modified:
6 years ago

People

(Reporter: Steffen Wilberg, Assigned: Steffen Wilberg)

Tracking

Version:
Trunk
Target:
Firefox 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

patch
3.26 KB, patch
mano
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
6 years ago 
The prefwindow doesn't need to hack around with setBoolPref.
setBoolPref applies instantly, which is wrong on Windows.
Use <preference>.value instead.
(Assignee)

Comment 1

•
6 years ago 
Created attachment 541363 [details] [diff] [review]
patch

The invertion of !pref.value is now done by the preference element's inverted="true".
Attachment #541363 - Flags: review?(mano)

Comment 2

•
6 years ago 
Comment on attachment 541363 [details] [diff] [review]
patch

r=mano
Attachment #541363 - Flags: review?(mano) → review+
 (Assignee)

Comment 3

•
6 years ago 
http://hg.mozilla.org/integration/mozilla-inbound/rev/28e4374838c4
Whiteboard: [inbound]

Comment 4

•
6 years ago 
Merged:
http://hg.mozilla.org/mozilla-central/rev/28e4374838c4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 7
You need to log in before you can comment on or make changes to this bug.