666576 - update removed-files.in with directories/files removed between 3.5 and 5.0

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[[e-mail] (:bhearsum)]

We're doing some updates to 3.5 (and 3.6) to 5.0, and getting a lot of spew in update verify runs with directories/files that have been removed, mostly because of omni.jar. We should fix this up in aurora/central to avoid such spewage when we do 6.0. The full list is:
source/bin: chrome
source/bin/defaults: autoconfig
source/bin/defaults: profile
source/bin/defaults/profile/chrome
source/bin: greprefs
source/bin: modules
source/bin: plugins
source/bin: res
source/bin/res/dtd
source/bin/res/entityTables
source/bin/res/fonts
source/bin/res/html
source/Firefox.app/Contents/MacOS: chrome
source/Firefox.app/Contents/MacOS/defaults: autoconfig
source/Firefox.app/Contents/MacOS/defaults: profile
source/Firefox.app/Contents/MacOS/defaults/profile/chrome
source/Firefox.app/Contents/MacOS: greprefs
source/Firefox.app/Contents/MacOS: modules
source/Firefox.app/Contents/MacOS: plugins
source/Firefox.app/Contents/MacOS/plugins/DefaultPlugin.plugin
source/Firefox.app/Contents/MacOS/plugins/DefaultPlugin.plugin/Contents
source/Firefox.app/Contents/MacOS/plugins/DefaultPlugin.plugin/Contents/MacOS
source/Firefox.app/Contents/MacOS/plugins/DefaultPlugin.plugin/Contents/Resources
source/Firefox.app/Contents/MacOS/plugins/DefaultPlugin.plugin/Contents/Resources/English.lproj
source/Firefox.app/Contents/MacOS/plugins/JavaEmbeddingPlugin.bundle
source/Firefox.app/Contents/MacOS/plugins/JavaEmbeddingPlugin.bundle/Contents
source/Firefox.app/Contents/MacOS/plugins/JavaEmbeddingPlugin.bundle/Contents/MacOS
source/Firefox.app/Contents/MacOS/plugins/JavaEmbeddingPlugin.bundle/Contents/Resources
source/Firefox.app/Contents/MacOS/plugins/JavaEmbeddingPlugin.bundle/Contents/Resources/English.lproj
source/Firefox.app/Contents/MacOS/plugins/JavaEmbeddingPlugin.bundle/Contents/Resources/Java
source/Firefox.app/Contents/MacOS/plugins/MRJPlugin.plugin
source/Firefox.app/Contents/MacOS/plugins/MRJPlugin.plugin/Contents
source/Firefox.app/Contents/MacOS/plugins/MRJPlugin.plugin/Contents/MacOS
source/Firefox.app/Contents/MacOS/plugins/MRJPlugin.plugin/Contents/Resources
source/Firefox.app/Contents/MacOS/plugins/MRJPlugin.plugin/Contents/Resources/English.lproj
source/Firefox.app/Contents/MacOS/res: dtd
source/Firefox.app/Contents/MacOS/res: entityTables
source/Firefox.app/Contents/MacOS/res: fonts
source/Firefox.app/Contents/MacOS/res: html
source/Firefox.app/Contents: Plug-Ins
source/Firefox.app/Contents/Plug-Ins/PrintPDE.plugin
source/Firefox.app/Contents/Plug-Ins/PrintPDE.plugin/Contents
source/Firefox.app/Contents/Plug-Ins/PrintPDE.plugin/Contents/MacOS
source/Firefox.app/Contents/Plug-Ins/PrintPDE.plugin/Contents/Resources
source/Firefox.app/Contents/Plug-Ins/PrintPDE.plugin/Contents/Resources/English.lproj
source/Firefox.app/Contents/Plug-Ins/PrintPDE.plugin/Contents/Resources/English.lproj/PrintPDE.nib
source/firefox/defaults: autoconfig
source/firefox/defaults: profile
source/firefox/defaults/profile/chrome
source/firefox: greprefs
source/firefox: modules
source/firefox: plugins
source/firefox: res
source/firefox/res/dtd
source/firefox/res/entityTables
source/firefox/res/fonts
source/firefox/res/html

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

per irc with bhearsum:

1) Its not possible to fix this in FF5.0.0 as its already shipped. Hence removing the depend link with bug663894

2) When this is fixed, this fix should be landed in mozilla-release (to fix in case of possible 5.0.1), as well as mozilla-beta (to fix for 6.0), mozilla-aurora (to fix for 7.0), and mozilla-central (to fix for 8.0 and beyond).

(legneato: we do not have a fix yet, but meanwhile, have I set the flags correctly?)

Comment 2

[Robert Strong (they/them - no direct email)]

Also, we can't remove directories when updating *from* a build that doesn't have directory removal such as any build from before Firefox 5.0, this has always been the case before Firefox 5.0, and the vast majority (perhaps all?) of the filesystem entries mentioned in comment #0 are for directories. If they are all directories then I believe this is wontfix. I'll take care of adding more directory removals in bug 649607 and I have already talked with Legneato about having a release where we require updating to a specific release which will simplify fixing bug 649607 significantly.

Comment 3

[[e-mail] (:bhearsum)]

Sounds like this is WONTFIX then. Thanks for weighing in, Rob.