User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:7.0a1) Gecko/20110621 Firefox/7.0a1 Build Identifier: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:7.0a1) Gecko/20110621 Firefox/7.0a1 Context menus do not appear on right click or left click inside the Dropbox web file manager. Clarifying I don't mean Firefox's regular context menus, but Dropbox's special ones. Also, the check boxes aren't working either. Reproducible: Always Steps to Reproduce: 1. Log in to dropbox.com 2. Right click on any file, drop down button or check box Actual Results: Nothing appears Expected Results: Dropbox context menu should appear or check box should be checked/unchecked. I'm not sure if this is a problem with Firefox or the site code. Alice0775 found this possible window: Works: http://hg.mozilla.org/tracemonkey/rev/e59b1d2a2f79 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110617 Firefox/7.0a1 ID:20110617173815 Fails: http://hg.mozilla.org/tracemonkey/rev/9ced98ee3aa9 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110618 Firefox/7.0a1 ID:20110618050724 Pushlog: http://hg.mozilla.org/tracemonkey/pushl ... ed98ee3aa9 Triggered by: 9ced98ee3aa9 Tom Schuster — Bug 640593 - Remove Function.arity and other cleanup around function properties r=jorendorff
We need to track this for fx7, right? Or did this make it into Fx6?
(In reply to comment #2) > We need to track this for fx7, right? Or did this make it into Fx6? Aurora doesn't have that changeset. This might be a TE thing--the regressing changeset removed a nonstandard language feature that Chrome and IE both lack. Maybe some browser detect code or Firefox option needs to be fixed?
Can someone who has a dropbox account attach the relevant scripts here?
Created attachment 541594 [details] sample html zip Zipped file ("Save Page As..." with "Web Page, complete")
Interesting. Those scripts don't seem to mention .arity...
Nothing obvious jumps out at me here. Tom?
Created attachment 541795 [details] [diff] [review] Patch We brought this up in a debugger and Jeff spotted the problem pretty easily. There were some unintentional cases to the control flow for .caller.
Created attachment 541798 [details] [diff] [review] Patch 2, same as before, but removes tabs
Comment on attachment 541798 [details] [diff] [review] Patch 2, same as before, but removes tabs Review of attachment 541798 [details] [diff] [review]: -----------------------------------------------------------------
Can we add tests for this?
6 years ago
Hey sorry about this... It wasn't clear to me that one of this calls behaves in such a strange way. Btw, i am 100% sure i commented in some other bug with the same issue and how to resolve it, shortly before camping.
The return false was of course plain stupid :(
cdleary-bot mozilla-central merge info: http://hg.mozilla.org/mozilla-central/rev/d1cdf4295626 Note: not marking as fixed because fixed-in-tracemonkey is not present on the whiteboard.
Tom, can you add a test for this please?
dmandelin, looks like we need to get this into Aurora. Is that the case or is there some reason this is m-c only?
(In reply to Asa Dotzler [:asa] from comment #20) > dmandelin, looks like we need to get this into Aurora. Is that the case or > is there some reason this is m-c only? AFAICT, it already made it to Aurora: changeset: 72140:d1cdf4295626 user: David Mandelin <firstname.lastname@example.org> date: Fri Jun 24 14:26:00 2011 -0700 summary: Bug 666587: revert accidentally changed control flow in fun_getProperty, r=jwalden
Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0 I have followed your steps on dropbox.com and it seems this issue has been fixed, since right-clicking on any item shows the context menu. And also left-clicking on checkboxes works. Setting resolution to VERIFIED FIXED. Thanks.