Closed
Bug 666587
Opened 13 years ago
Closed 13 years ago
Context menus do not work on Dropbox
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
VERIFIED
FIXED
mozilla7
Tracking | Status | |
---|---|---|
firefox5 | --- | unaffected |
firefox6 | --- | unaffected |
firefox7 | + | fixed |
People
(Reporter: rodrigozeh, Assigned: dmandelin)
References
()
Details
(Keywords: regression, Whiteboard: fixed-in-tracemonkey)
Attachments
(2 files, 1 obsolete file)
180.79 KB,
application/x-zip-compressed
|
Details | |
2.34 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:7.0a1) Gecko/20110621 Firefox/7.0a1 Build Identifier: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:7.0a1) Gecko/20110621 Firefox/7.0a1 Context menus do not appear on right click or left click inside the Dropbox web file manager. Clarifying I don't mean Firefox's regular context menus, but Dropbox's special ones. Also, the check boxes aren't working either. Reproducible: Always Steps to Reproduce: 1. Log in to dropbox.com 2. Right click on any file, drop down button or check box Actual Results: Nothing appears Expected Results: Dropbox context menu should appear or check box should be checked/unchecked. I'm not sure if this is a problem with Firefox or the site code. Alice0775 found this possible window: Works: http://hg.mozilla.org/tracemonkey/rev/e59b1d2a2f79 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110617 Firefox/7.0a1 ID:20110617173815 Fails: http://hg.mozilla.org/tracemonkey/rev/9ced98ee3aa9 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110618 Firefox/7.0a1 ID:20110618050724 Pushlog: http://hg.mozilla.org/tracemonkey/pushl ... ed98ee3aa9 Triggered by: 9ced98ee3aa9 Tom Schuster — Bug 640593 - Remove Function.arity and other cleanup around function properties r=jorendorff
Correct Pushlog link: http://hg.mozilla.org/tracemonkey/pushloghtml?fromchange=e59b1d2a2f79&tochange=9ced98ee3aa9
Updated•13 years ago
|
Assignee: nobody → general
Component: General → JavaScript Engine
Depends on: 640593
Product: Firefox → Core
QA Contact: general → general
Version: unspecified → Trunk
Comment 2•13 years ago
|
||
We need to track this for fx7, right? Or did this make it into Fx6?
Blocks: 640593
Status: UNCONFIRMED → NEW
tracking-firefox7:
--- → ?
No longer depends on: 640593
Ever confirmed: true
Keywords: regression
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to comment #2) > We need to track this for fx7, right? Or did this make it into Fx6? Aurora doesn't have that changeset. This might be a TE thing--the regressing changeset removed a nonstandard language feature that Chrome and IE both lack. Maybe some browser detect code or Firefox option needs to be fixed?
status-firefox5:
--- → unaffected
status-firefox6:
--- → unaffected
Comment 4•13 years ago
|
||
Can someone who has a dropbox account attach the relevant scripts here?
Comment 5•13 years ago
|
||
Zipped file ("Save Page As..." with "Web Page, complete")
Comment 6•13 years ago
|
||
Interesting. Those scripts don't seem to mention .arity...
Comment 7•13 years ago
|
||
Nothing obvious jumps out at me here. Tom?
Assignee | ||
Comment 8•13 years ago
|
||
We brought this up in a debugger and Jeff spotted the problem pretty easily. There were some unintentional cases to the control flow for .caller.
Assignee: general → dmandelin
Status: NEW → ASSIGNED
Attachment #541795 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 9•13 years ago
|
||
Attachment #541798 -
Flags: review?(jwalden+bmo)
Comment 10•13 years ago
|
||
Comment on attachment 541798 [details] [diff] [review] Patch 2, same as before, but removes tabs Review of attachment 541798 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #541798 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Updated•13 years ago
|
Attachment #541795 -
Attachment is obsolete: true
Attachment #541795 -
Flags: review?(jwalden+bmo)
Comment 12•13 years ago
|
||
Can we add tests for this?
Comment 13•13 years ago
|
||
Hey sorry about this... It wasn't clear to me that one of this calls behaves in such a strange way. Btw, i am 100% sure i commented in some other bug with the same issue and how to resolve it, shortly before camping.
Comment 14•13 years ago
|
||
The return false was of course plain stupid :(
Comment 15•13 years ago
|
||
cdleary-bot mozilla-central merge info: http://hg.mozilla.org/mozilla-central/rev/d1cdf4295626 Note: not marking as fixed because fixed-in-tracemonkey is not present on the whiteboard.
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-tracemonkey
Comment 16•13 years ago
|
||
Tom, can you add a test for this please?
Comment 19•13 years ago
|
||
Tests for this were landed as part of bug 667646 and bug 667538.
Target Milestone: --- → mozilla7
Updated•13 years ago
|
tracking-firefox7:
? → ---
Updated•13 years ago
|
tracking-firefox7:
--- → +
Comment 20•13 years ago
|
||
dmandelin, looks like we need to get this into Aurora. Is that the case or is there some reason this is m-c only?
Assignee | ||
Comment 21•13 years ago
|
||
(In reply to Asa Dotzler [:asa] from comment #20) > dmandelin, looks like we need to get this into Aurora. Is that the case or > is there some reason this is m-c only? AFAICT, it already made it to Aurora: changeset: 72140:d1cdf4295626 user: David Mandelin <dmandelin@mozilla.com> date: Fri Jun 24 14:26:00 2011 -0700 summary: Bug 666587: revert accidentally changed control flow in fun_getProperty, r=jwalden
status-firefox7:
--- → fixed
Comment 22•13 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0 I have followed your steps on dropbox.com and it seems this issue has been fixed, since right-clicking on any item shows the context menu. And also left-clicking on checkboxes works. Setting resolution to VERIFIED FIXED. Thanks.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•