666621 - jpeg/ - compiler warnings with gcc ("'main' is usually a function", and "section flags ignored on section redeclaration")

Status: RESOLVED INCOMPLETE

(Core :: Graphics, defect)

Description

[Joey Armstrong [:joey]]

% uname -a
Darwin banshee.local 10.7.4 Darwin Kernel Version 10.7.4: Mon Apr 18 21:24:17 PDT 2011; root:xnu-1504.14.12~3/RELEASE_X86_64 x86_64



/mozilla/sandbox/gml/jpeg/jdmainct.c:164: warning: 'main' is usually a function
/mozilla/sandbox/gml/jpeg/jdmainct.c:205: warning: 'main' is usually a function
/mozilla/sandbox/gml/jpeg/jdmainct.c:245: warning: 'main' is usually a function
/mozilla/sandbox/gml/jpeg/jdmainct.c:274: warning: 'main' is usually a function
/mozilla/sandbox/gml/jpeg/jdmainct.c:311: warning: 'main' is usually a function
/mozilla/sandbox/gml/jpeg/jdmainct.c:351: warning: 'main' is usually a function
/mozilla/sandbox/gml/jpeg/jdmainct.c:391: warning: 'main' is usually a function
/mozilla/sandbox/gml/jpeg/jdmainct.c:480: warning: 'main' is usually a function
/mozilla/sandbox/gml/jpeg/jcmainct.c:71: warning: 'main' is usually a function
/mozilla/sandbox/gml/jpeg/jcmainct.c:117: warning: 'main' is usually a function
/mozilla/sandbox/gml/jpeg/jcmainct.c:247: warning: 'main' is usually a function
/mozilla/sandbox/gml/jpeg/simd/jccolss2-64.asm:34: warning: section flags ignored on section redeclaration
/mozilla/sandbox/gml/jpeg/simd/jdsamss2-64.asm:23: warning: section flags ignored on section redeclaration
/mozilla/sandbox/gml/jpeg/simd/jfss2fst-64.asm:47: warning: section flags ignored on section redeclaration
/mozilla/sandbox/gml/jpeg/simd/jfss2int-64.asm:67: warning: section flags ignored on section redeclaration
/mozilla/sandbox/gml/jpeg/simd/jdcolss2-64.asm:35: warning: section flags ignored on section redeclaration
/mozilla/sandbox/gml/jpeg/simd/jfsseflt-64.asm:38: warning: section flags ignored on section redeclaration
/mozilla/sandbox/gml/jpeg/simd/jiss2flt-64.asm:38: warning: section flags ignored on section redeclaration
/mozilla/sandbox/gml/jpeg/simd/jdmerss2-64.asm:35: warning: section flags ignored on section redeclaration
/mozilla/sandbox/gml/jpeg/simd/jiss2fst-64.asm:54: warning: section flags ignored on section redeclaration
/mozilla/sandbox/gml/jpeg/simd/jiss2int-64.asm:67: warning: section flags ignored on section redeclaration
/mozilla/sandbox/gml/jpeg/simd/jiss2red-64.asm:73: warning: section flags ignored on section redeclaration

Comment 1

[Atul Aggarwal]

Attachment: Patch v1

Based on https://bugzilla.mozilla.org/attachment.cgi?id=463896&action=diff on current mozilla-central branch.

Comment 2

[Justin Lebar (not reading bugmail)]

Comment on attachment 556853 [details] [diff] [review]
Patch v1

Does this fix the "section flags ignored on section redeclaration" warning?

Comment 3

[Atul Aggarwal]

Justin, Not actually. I really don't know the reason for this warning. I should have mentioned in the patch about it but I forgot to do so.

Comment 5

[Justin Lebar (not reading bugmail)]

So then this isn't really a dupe of 585414, because that bug contains just one warning, and this one contains two.  Would you mind editing the summary of this bug so it reflects what you're fixing here?

Comment 6

[Atul Aggarwal]

Justin, I agree this is not a duplicate but this bug is super-set of bug 585414. Currently I am only fixing the first part of the bug (which involves errors in *.c files).

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 556853 [details] [diff] [review]
Patch v1

I'd rather fix this upstream or disable this warning for libjpeg.

Comment 8

[Atul Aggarwal]

How feasible it is to fix this upstream knowing that it would impact multiple files for just compiler warnings?

Comment 9

[Justin Lebar (not reading bugmail)]

(In reply to Atul Aggarwal from comment #8)
> How feasible it is to fix this upstream knowing that it would impact
> multiple files for just compiler warnings?

I don't know, but you could send an e-mail to the libjpeg-turbo mailing list.

Comment 10

[Atul Aggarwal]

(In reply to Justin Lebar [:jlebar] from comment #9)
> (In reply to Atul Aggarwal from comment #8)
> > How feasible it is to fix this upstream knowing that it would impact
> > multiple files for just compiler warnings?
> 
> I don't know, but you could send an e-mail to the libjpeg-turbo mailing list.

Sent an email to libjpeg-turbo-devel mailing list. Waiting for their reply and will act accordingly.

Comment 11

[DRC]

I applied a patch to fix the "main" warnings but am unsure what is causing the assembler warnings.  I don't see those on any of my systems.

Comment 12

[Atul Aggarwal]

DRC, When will the patch submitted by me be applied to libjpeg-turbo?

Comment 13

[DRC]

Your patch had to be modified slightly, but as I indicated above, the portion of it that fixes the "main" warnings has been applied (in trunk.)

I am unwilling to apply the rest of the patch until it is understood why the assembler warnings are occurring.  I cannot currently reproduce those, nor do I have time to diagnose them (nor do I really care, frankly, as long as the code builds and runs properly.)

Comment 14

[Atul Aggarwal]

DRC, Good enough for me. I also have no idea why assembler warnings are being thrown but we should fix "main" warnings.
Thanks a lot for such quick turnaround.

Comment 15

[Joe Drew (not getting mail)]

Given that DRC's applied the relevant bits upstream, let's call this Mozilla bug finished.