The default bug view has changed. See this FAQ.

Reflect HTMLMediaElement.preload like an enumerated attribute

RESOLVED FIXED in mozilla8

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

({dev-doc-complete})

Trunk
mozilla8
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 541440 [details] [diff] [review]
Patch v1
Attachment #541440 - Flags: review?(bzbarsky)
Comment on attachment 541440 [details] [diff] [review]
Patch v1

r=me
Attachment #541440 - Flags: review?(bzbarsky) → review+
Yay 666666 !!!!!!
Comment on attachment 541440 [details] [diff] [review]
Patch v1

Review of attachment 541440 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/test/test_bug660663.html
@@ +29,5 @@
> +                         []);
> +reflectLimitedEnumerated(document.createElement("audio"),
> +                         "preload",
> +                         ["none", "metadata", "auto"],
> +                         []);

I think that would be a better idea to create a new file instead of adding these tests here. If you want to create a test suite for attribute reflection, splitting it by element would probably be better than doing that in the same file.

Not critical, though.
Oh, and thank you very much for fixing that :)
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/mozilla-central/rev/e00f235a80e4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Keywords: dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
The https://developer.mozilla.org/en/DOM/HTMLMediaElement document is up-to-date regarding this change (I fixed a small typo and the type).

I added a sentence to Firefox 8 for developers, too.
Keywords: dev-doc-needed → dev-doc-complete

Updated

5 years ago
Blocks: 666667

Updated

5 years ago
No longer blocks: 666667
You need to log in before you can comment on or make changes to this bug.