666667 - Clean up descriptions in TelemetryHistograms.h

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Justin Lebar (not reading bugmail)]

TelemetryHistograms.h:

HISTOGRAM(MEMORY_JS_GC_HEAP, 1024, 512 * 1024, 10, EXPONENTIAL, "Memory(MB) used by the JavaScript GC")
HISTOGRAM(MEMORY_RESIDENT, 32 * 1024, 1024 * 1024, 10, EXPONENTIAL, "Resident memory(MB) reported by OS")
HISTOGRAM(MEMORY_LAYOUT_ALL, 1024, 64 * 1024, 10, EXPONENTIAL, "Memory(MB) reported used by layout")

But TelemetryPing.js:

name = "Memory:" + mr.path + " + (KB)";
val = Math.floor(mr.amount / 1024);

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Patch v1

Comment 2

[Justin Lebar (not reading bugmail)]

Now that I have a closer look at the file, I think many of these descriptions need to be cleaned up (and my patch doesn't follow the existing convention).  I'll try again in a moment.

Comment 3

[Justin Lebar (not reading bugmail)]

Attachment: Patch v2

Comment 4

[(dormant account)]

Comment on attachment 541444 [details] [diff] [review]
Patch v2

Please also get rid of 
let name = "Memory:" + mr.path + " (KB)";
 and just use mr.name as a key in _histograms

Comment 5

[Mike Hommey [:glandium]]

> HISTOGRAM(HARD_PAGE_FAULTS, 1024, 1024 * 1024, 10, EXPONENTIAL, "Hard page faults (cumulative)")

where does that come from?

Comment 6

[(dormant account)]

(In reply to comment #5)
> > HISTOGRAM(HARD_PAGE_FAULTS, 1024, 1024 * 1024, 10, EXPONENTIAL, "Hard page faults (cumulative)")
> 
> where does that come from?

bug 664486

Comment 7

[Justin Lebar (not reading bugmail)]

Pushed to m-i:

http://hg.mozilla.org/integration/mozilla-inbound/rev/a6cdfd70d6a2

Comment 8

[Joe Drew (not getting mail)]

http://hg.mozilla.org/mozilla-central/rev/a6cdfd70d6a2