Closed Bug 666667 Opened 10 years ago Closed 10 years ago

Clean up descriptions in TelemetryHistograms.h

Categories

(Toolkit :: Telemetry, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: justin.lebar+bug, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

TelemetryHistograms.h:

HISTOGRAM(MEMORY_JS_GC_HEAP, 1024, 512 * 1024, 10, EXPONENTIAL, "Memory(MB) used by the JavaScript GC")
HISTOGRAM(MEMORY_RESIDENT, 32 * 1024, 1024 * 1024, 10, EXPONENTIAL, "Resident memory(MB) reported by OS")
HISTOGRAM(MEMORY_LAYOUT_ALL, 1024, 64 * 1024, 10, EXPONENTIAL, "Memory(MB) reported used by layout")

But TelemetryPing.js:

name = "Memory:" + mr.path + " + (KB)";
val = Math.floor(mr.amount / 1024);
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #541442 - Flags: review?(tglek)
Now that I have a closer look at the file, I think many of these descriptions need to be cleaned up (and my patch doesn't follow the existing convention).  I'll try again in a moment.
Summary: Update TelemetryHistograms.h to indicate that memory is reported in KB, not MB → Clean up descriptions in TelemetryHistograms.h
Attachment #541442 - Attachment is obsolete: true
Attachment #541442 - Flags: review?(tglek)
Attached patch Patch v2Splinter Review
Attachment #541444 - Flags: review?(tglek)
Depends on: 664486
Comment on attachment 541444 [details] [diff] [review]
Patch v2

Please also get rid of 
let name = "Memory:" + mr.path + " (KB)";
 and just use mr.name as a key in _histograms
Attachment #541444 - Flags: review?(tglek) → review+
> HISTOGRAM(HARD_PAGE_FAULTS, 1024, 1024 * 1024, 10, EXPONENTIAL, "Hard page faults (cumulative)")

where does that come from?
(In reply to comment #5)
> > HISTOGRAM(HARD_PAGE_FAULTS, 1024, 1024 * 1024, 10, EXPONENTIAL, "Hard page faults (cumulative)")
> 
> where does that come from?

bug 664486
http://hg.mozilla.org/mozilla-central/rev/a6cdfd70d6a2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Depends on: 666666
No longer depends on: 666666
You need to log in before you can comment on or make changes to this bug.