666679 - gfx/ - compiler warnings on mac

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Joey Armstrong [:joey]]

uname -a
Darwin banshee.local 10.7.4 Darwin Kernel Version 10.7.4: Mon Apr 18 21:24:17 PDT 2011; root:xnu-1504.14.12~3/RELEASE_X86_64 x86_64

/mozilla/sandbox/gml/gfx/src/nsRect.cpp:51: warning: 'bool IsFloatInteger(float)' defined but not used
/mozilla/sandbox/gml/gfx/layers/basic/BasicLayers.cpp:782: warning: 'virtual already_AddRefed<gfxASurface> mozilla::layers::BasicThebesLayerBuffer::CreateBuffer(gfxASurface::gfxContentType, const nsIntSize&, PRUint32)' was hidden
/mozilla/sandbox/gml/gfx/layers/basic/BasicLayers.cpp:2436: warning:   by 'virtual already_AddRefed<gfxASurface> mozilla::layers::ShadowThebesLayerBuffer::CreateBuffer(gfxASurface::gfxContentType, const nsIntSize&)'

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to comment #0)
> /mozilla/sandbox/gml/gfx/src/nsRect.cpp:51: warning: 'bool
> IsFloatInteger(float)' defined but not used

Jeff Gilbert (new gfx hire) is fixing this warning over in bug 669522, as a first bug.

Comment 2

[Atul Aggarwal]

Current warning status after bug 669522 is marked as fixed.

/mozilla/mozilla-central/gfx/layers/basic/BasicLayers.cpp: In member function âvoid mozilla::layers::BasicThebesLayerBuffer::SetBackingBuffer(gfxASurface*, const nsIntRect&, const nsIntPoint&)â:
/mozilla/mozilla-central/gfx/layers/basic/BasicLayers.cpp:438:16: warning: variable âprevSizeâ set but not used [-Wunused-but-set-variable]
/mozilla/mozilla-central/gfx/layers/basic/BasicLayers.cpp:439:16: warning: variable ânewSizeâ set but not used [-Wunused-but-set-variable]
/mozilla/mozilla-central/gfx/layers/basic/BasicLayers.cpp: At global scope:
/mozilla/mozilla-central/gfx/layers/basic/BasicLayers.cpp:803:1: warning: âvirtual already_AddRefed<gfxASurface> mozilla::layers::BasicThebesLayerBuffer::CreateBuffer(mozilla::layers::ThebesLayerBuffer::ContentType, const nsIntSize&, PRUint32)â was hidden [-Woverloaded-virtual]
/mozilla/mozilla-central/gfx/layers/basic/BasicLayers.cpp:2690:3: warning:   by âvirtual already_AddRefed<gfxASurface> mozilla::layers::ShadowThebesLayerBuffer::CreateBuffer(mozilla::layers::ThebesLayerBuffer::ContentType, const nsIntSize&)â [-Woverloaded-virtual]
/mozilla/mozilla-central/gfx/layers/basic/BasicLayers.cpp: In member function âvirtual void mozilla::layers::BasicCanvasLayer::PaintWithOpacity(gfxContext*, float)â:
/mozilla/mozilla-central/gfx/layers/basic/BasicLayers.cpp:1225:35: warning: âsavedOpâ may be used uninitialized in this function [-Wuninitialized]
/mozilla/mozilla-central/gfx/layers/basic/BasicLayers.cpp:1202:32: note: âsavedOpâ was declared here

Comment 3

[:Cykesiopka]

FWIW, Bug 783841 fixed:
BasicLayers.cpp:438:16: warning: variable 'prevSize' set but not used
BasicLayers.cpp:439:16: warning: variable 'newSize' set but not used

Comment 4

[Chris Peterson [:cpeterson]]

These warnings have been fixed and gfx/layers/ is now built with warnings-as-errors.