666717 - URL bar highlighting treats URLs with hyphenated schemes (e.g. view-source) as scheme-less

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

I took the list of allowed characters from <http://en.wikipedia.org/wiki/URI_scheme#Generic_syntax>.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Err, instead of changing tragetValue to targetValue, I did it the other way around...

Comment 3

[Daniel C]

Thanks for fixing this quickly.

let protocol = value.match(/^[a-z\d.+-]+:/);

I think this would be clearer with the special characters .+- escaped (\.\+\-). It has the same effect but it looks odd (to me at least) to have an unescaped . that is actually a literal and +- suggests the start of a character range.

I think that a line should be added to browser_urlbarTrimURLs.js test like:

testVal("view-source:http://www.mozilla.org/");

And maybe another nested scheme like:

testVal("jar:http://www.mozilla.org/example.jar!/");

could be added to both that test and the highlighting test (unless you plan to have the domain highlighted in that case).

Comment 4

[Dão Gottwald [:dao]]

> I think this would be clearer with the special characters .+- escaped
> (\.\+\-). It has the same effect but it looks odd (to me at least) to have
> an unescaped . that is actually a literal and +- suggests the start of a
> character range.

I escaped the hyphen, since it actually does have a special meaning in character classes, e.g. .-+ wouldn't work.

> I think that a line should be added to browser_urlbarTrimURLs.js test like:
> 
> testVal("view-source:http://www.mozilla.org/");
> 
> And maybe another nested scheme like:
> 
> testVal("jar:http://www.mozilla.org/example.jar!/");
> 
> could be added to both that test and the highlighting test (unless you plan
> to have the domain highlighted in that case).

done

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/e0b805cab438