Closed
Bug 666842
Opened 13 years ago
Closed 13 years ago
Use an ellipsis for long tab names in Panorama
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 7
People
(Reporter: pcwalton, Assigned: pcwalton)
Details
(Whiteboard: [inbound])
Attachments
(1 file, 3 obsolete files)
|
2.25 KB,
patch
|
Details | Diff | Splinter Review |
Now that text-overflow: ellipsis has landed, this is trivial. We can simply trim long tab names in Panorama with an ellipsis.
|
Assignee | |
Updated•13 years ago
|
Attachment #541600 -
Attachment is patch: true
Attachment #541600 -
Flags: review?(tim.taubert)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 541600 [details] [diff] [review]
Proposed patch.
This belongs in browser/base/content/tabview/tabview.css.
> .tab-title {
> top: 100%;
> text-align: center;
> width: 94.5%;
> white-space: nowrap;
> overflow: hidden;
>+ text-overflow: ellipsis;
> }
Is overflow:hidden still needed?
Attachment #541600 -
Flags: review?(tim.taubert) → review-
|
||
Comment 2•13 years ago
|
||
We should watch out for bug 666669 as this might pref off "text-overflow: ellipsis" for Fx 7.
|
|
Assignee | |
Comment 3•13 years ago
|
||
Patch version 2 moves the text-overflow to browser/base/content/tabview.css.
The overflow: hidden is indeed still needed.
Assignee: nobody → pwalton
Attachment #541600 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #541974 -
Flags: review?(dao)
|
|
||
Comment 4•13 years ago
|
||
(In reply to comment #3)
> The overflow: hidden is indeed still needed.
What is it needed for?
|
|
Assignee | |
Comment 5•13 years ago
|
||
(In reply to comment #4)
> (In reply to comment #3)
> > The overflow: hidden is indeed still needed.
>
> What is it needed for?
To prevent the tab name from overflowing its bounds. text-overflow only specifies what to do if overflow occurs, not whether to do overflow. See MDC docs:
https://developer.mozilla.org/En/CSS/text-overflow
|
|
||
Comment 6•13 years ago
|
||
It should be in content CSS along with text-overflow, then.
|
|
Assignee | |
Comment 7•13 years ago
|
||
Patch version 3 moves overflow.
Attachment #541974 -
Attachment is obsolete: true
Attachment #541997 -
Flags: review?(dao)
Attachment #541974 -
Flags: review?(dao)
|
|
||
Comment 8•13 years ago
|
||
Comment on attachment 541997 [details] [diff] [review]
Proposed patch, version 3.
> white-space: nowrap;
This too.
Attachment #541997 -
Flags: review?(dao) → review+
|
|
Assignee | |
Comment 9•13 years ago
|
||
Patch version 4 moves white-space too.
Attachment #541997 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 11•13 years ago
|
||
Keywords: checkin-needed
Whiteboard: [inbound]
|
||
Comment 12•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
|
||
Comment 13•13 years ago
|
||
Mozilla/5.0 (X11; Linux i686; rv:7.0a2) Gecko/20110706 Firefox/7.0a2
Verified issue on Ubuntu 11.04 x86, WinXP, Mac OS X 10.6, Win7 x86 and long website titles are no longer truncated but instead the ellipsis is shown.
Setting status Verified Fixed.
Status: RESOLVED → VERIFIED
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•