Use an ellipsis for long tab names in Panorama

VERIFIED FIXED in Firefox 7

Status

Firefox Graveyard
Panorama
--
minor
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: pcwalton, Assigned: pcwalton)

Tracking

unspecified
Firefox 7

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 541600 [details] [diff] [review]
Proposed patch.

Now that text-overflow: ellipsis has landed, this is trivial. We can simply trim long tab names in Panorama with an ellipsis.
(Assignee)

Updated

6 years ago
Attachment #541600 - Attachment is patch: true
Attachment #541600 - Flags: review?(tim.taubert)
Comment on attachment 541600 [details] [diff] [review]
Proposed patch.

This belongs in browser/base/content/tabview/tabview.css.

> .tab-title {
>   top: 100%;
>   text-align: center;
>   width: 94.5%;
>   white-space: nowrap;
>   overflow: hidden;
>+  text-overflow: ellipsis;
> }

Is overflow:hidden still needed?
Attachment #541600 - Flags: review?(tim.taubert) → review-
We should watch out for bug 666669 as this might pref off "text-overflow: ellipsis" for Fx 7.
(Assignee)

Comment 3

6 years ago
Created attachment 541974 [details] [diff] [review]
Proposed patch, version 2.

Patch version 2 moves the text-overflow to browser/base/content/tabview.css.

The overflow: hidden is indeed still needed.
Assignee: nobody → pwalton
Attachment #541600 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #541974 - Flags: review?(dao)
(In reply to comment #3)
> The overflow: hidden is indeed still needed.

What is it needed for?
(Assignee)

Comment 5

6 years ago
(In reply to comment #4)
> (In reply to comment #3)
> > The overflow: hidden is indeed still needed.
> 
> What is it needed for?

To prevent the tab name from overflowing its bounds. text-overflow only specifies what to do if overflow occurs, not whether to do overflow. See MDC docs:

https://developer.mozilla.org/En/CSS/text-overflow
It should be in content CSS along with text-overflow, then.
(Assignee)

Comment 7

6 years ago
Created attachment 541997 [details] [diff] [review]
Proposed patch, version 3.

Patch version 3 moves overflow.
Attachment #541974 - Attachment is obsolete: true
Attachment #541997 - Flags: review?(dao)
Attachment #541974 - Flags: review?(dao)
Comment on attachment 541997 [details] [diff] [review]
Proposed patch, version 3.

>   white-space: nowrap;

This too.
Attachment #541997 - Flags: review?(dao) → review+
(Assignee)

Comment 9

6 years ago
Created attachment 541998 [details] [diff] [review]
Proposed patch, version 4.

Patch version 4 moves white-space too.
Attachment #541997 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Duplicate of this bug: 589132
(Assignee)

Comment 11

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/622f3e5f6c17
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/622f3e5f6c17
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7

Comment 13

6 years ago
Mozilla/5.0 (X11; Linux i686; rv:7.0a2) Gecko/20110706 Firefox/7.0a2

Verified issue on Ubuntu 11.04 x86, WinXP, Mac OS X 10.6, Win7 x86 and long website titles are no longer truncated but instead the ellipsis is shown.

Setting status Verified Fixed.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.