Closed Bug 667075 Opened 9 years ago Closed 9 years ago

Safe Browsing shouldn't use SQL queries to generate random numbers

Categories

(Toolkit :: Safe Browsing, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 8

People

(Reporter: gcp, Assigned: gcp)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file)

nsresult nsUrlClassifierStore::RandomNumber(PRInt64 *randomNum) uses queries to SQLITE to generate random numbers.

This perversion exists because of bug 419739, but that seems to have been fixed by bug 607115 now.

I'm going to get rid of this if only because it makes my eyes hurt.
Assignee: nobody → gpascutto
Attachment #549075 - Flags: review?(dcamp) → review+
Keywords: checkin-needed
Summary: Safe Browsing use SQL queries to generate random numbers → Safe Browsing shouldn't use SQL queries to generate random numbers
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/b4165ae3685f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Depends on: 691364
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.