The default bug view has changed. See this FAQ.

Safe Browsing shouldn't use SQL queries to generate random numbers

RESOLVED FIXED in Firefox 8

Status

()

Toolkit
Safe Browsing
--
minor
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: gcp, Assigned: gcp)

Tracking

Trunk
Firefox 8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
nsresult nsUrlClassifierStore::RandomNumber(PRInt64 *randomNum) uses queries to SQLITE to generate random numbers.

This perversion exists because of bug 419739, but that seems to have been fixed by bug 607115 now.

I'm going to get rid of this if only because it makes my eyes hurt.
(Assignee)

Updated

6 years ago
Assignee: nobody → gpascutto
(Assignee)

Comment 1

6 years ago
Created attachment 549075 [details] [diff] [review]
Patch v1 Use nsIRandomGenerator instead of querying SQLite.

http://tbpl.mozilla.org/?tree=Try&rev=b913d9c2915e
Attachment #549075 - Flags: review?(dcamp)

Updated

6 years ago
Attachment #549075 - Flags: review?(dcamp) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Summary: Safe Browsing use SQL queries to generate random numbers → Safe Browsing shouldn't use SQL queries to generate random numbers

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/b4165ae3685f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8

Updated

5 years ago
Depends on: 691364
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.