Closed
Bug 667075
Opened 14 years ago
Closed 14 years ago
Safe Browsing shouldn't use SQL queries to generate random numbers
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
Firefox 8
People
(Reporter: gcp, Assigned: gcp)
References
Details
(Whiteboard: [inbound])
Attachments
(1 file)
|
5.50 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
nsresult nsUrlClassifierStore::RandomNumber(PRInt64 *randomNum) uses queries to SQLITE to generate random numbers.
This perversion exists because of bug 419739, but that seems to have been fixed by bug 607115 now.
I'm going to get rid of this if only because it makes my eyes hurt.
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → gpascutto
|
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #549075 -
Flags: review?(dcamp)
|
||
Updated•14 years ago
|
Attachment #549075 -
Flags: review?(dcamp) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Updated•14 years ago
|
Summary: Safe Browsing use SQL queries to generate random numbers → Safe Browsing shouldn't use SQL queries to generate random numbers
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
Whiteboard: [inbound]
|
||
Comment 2•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
|
||
Updated•11 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•